From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.crosthwaite@xilinx.com
Subject: [Qemu-devel] [PATCH 1/9] qom: object: delete properties before calling instance_finalize
Date: Wed, 30 Jul 2014 12:27:04 +0200 [thread overview]
Message-ID: <1406716032-21795-2-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1406716032-21795-1-git-send-email-pbonzini@redhat.com>
This ensures that the children's unparent callback will still
have a usable parent.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
qom/object.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qom/object.c b/qom/object.c
index 0e8267b..f301bc2 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -418,8 +418,8 @@ static void object_finalize(void *data)
Object *obj = data;
TypeImpl *ti = obj->class->type;
- object_deinit(obj, ti);
object_property_del_all(obj);
+ object_deinit(obj, ti);
g_assert(obj->ref == 0);
if (obj->free) {
--
1.8.3.1
next prev parent reply other threads:[~2014-07-30 10:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 10:27 [Qemu-devel] [PATCH for-2.2 0/9] memory: remove memory_region_destroy Paolo Bonzini
2014-07-30 10:27 ` Paolo Bonzini [this message]
2014-07-31 11:41 ` [Qemu-devel] [PATCH 1/9] qom: object: delete properties before calling instance_finalize Peter Crosthwaite
2014-07-30 10:27 ` [Qemu-devel] [PATCH 2/9] qom: object: move unparenting to the child property's release callback Paolo Bonzini
2014-07-30 10:27 ` [Qemu-devel] [PATCH 3/9] sysbus: remove unused function sysbus_del_io Paolo Bonzini
2014-07-31 4:04 ` Peter Crosthwaite
2014-07-30 10:27 ` [Qemu-devel] [PATCH 4/9] vga: do not dynamically allocate chain4_alias Paolo Bonzini
2014-07-31 12:01 ` Peter Crosthwaite
2014-07-31 12:06 ` Paolo Bonzini
2014-07-30 10:27 ` [Qemu-devel] [PATCH 5/9] nic: do not destroy memory regions in cleanup functions Paolo Bonzini
2014-07-31 9:46 ` Stefan Hajnoczi
2014-07-31 12:06 ` Peter Crosthwaite
2014-07-30 10:27 ` [Qemu-devel] [PATCH 6/9] ioport: split deletion and destruction Paolo Bonzini
2014-07-31 12:34 ` Peter Crosthwaite
2014-07-31 14:30 ` Paolo Bonzini
2014-07-30 10:27 ` [Qemu-devel] [PATCH 7/9] memory: convert memory_region_destroy to object_unparent Paolo Bonzini
2014-07-30 10:27 ` [Qemu-devel] [PATCH 8/9] memory: remove memory_region_destroy Paolo Bonzini
2014-07-31 12:52 ` Peter Crosthwaite
2014-08-15 7:23 ` Peter Crosthwaite
2014-07-30 10:27 ` [Qemu-devel] [PATCH 9/9] tpm_tis: remove instance_finalize callback Paolo Bonzini
2014-07-31 12:00 ` Peter Crosthwaite
2014-07-31 12:05 ` Paolo Bonzini
2014-07-31 13:02 ` Peter Crosthwaite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406716032-21795-2-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).