From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39718) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCml8-0000Le-6t for qemu-devel@nongnu.org; Thu, 31 Jul 2014 05:35:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XCmkr-0003aw-4o for qemu-devel@nongnu.org; Thu, 31 Jul 2014 05:34:50 -0400 Received: from e23smtp01.au.ibm.com ([202.81.31.143]:41181) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCmkq-0003Zi-GI for qemu-devel@nongnu.org; Thu, 31 Jul 2014 05:34:33 -0400 Received: from /spool/local by e23smtp01.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 31 Jul 2014 19:34:26 +1000 From: Alexey Kardashevskiy Date: Thu, 31 Jul 2014 19:34:06 +1000 Message-Id: <1406799254-25223-3-git-send-email-aik@ozlabs.ru> In-Reply-To: <1406799254-25223-1-git-send-email-aik@ozlabs.ru> References: <1406799254-25223-1-git-send-email-aik@ozlabs.ru> Subject: [Qemu-devel] [RFC PATCH 02/10] spapr_iommu: Disable in-kernel IOMMU tables for >4GB windows List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Alexey Kardashevskiy , Alex Williamson , qemu-ppc@nongnu.org, Alexander Graf The existing KVM_CREATE_SPAPR_TCE ioctl only support 4G windows max. We are going to add huge DMA windows support so this will create small window and unexpectedly fail later. This disables KVM_CREATE_SPAPR_TCE for windows bigger that 4GB. Since those windows are normally mapped at the boot time, there will be no performance impact. Signed-off-by: Alexey Kardashevskiy --- hw/ppc/spapr_iommu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/ppc/spapr_iommu.c b/hw/ppc/spapr_iommu.c index f6e32a4..36f5d27 100644 --- a/hw/ppc/spapr_iommu.c +++ b/hw/ppc/spapr_iommu.c @@ -113,11 +113,11 @@ static MemoryRegionIOMMUOps spapr_iommu_ops = { static int spapr_tce_table_realize(DeviceState *dev) { sPAPRTCETable *tcet = SPAPR_TCE_TABLE(dev); + uint64_t window_size = tcet->nb_table << tcet->page_shift; - if (kvm_enabled()) { + if (kvm_enabled() && !(window_size >> 32)) { tcet->table = kvmppc_create_spapr_tce(tcet->liobn, - tcet->nb_table << - tcet->page_shift, + window_size, &tcet->fd, tcet->vfio_accel); } -- 2.0.0