From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48841) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XDrYK-00025e-R3 for qemu-devel@nongnu.org; Sun, 03 Aug 2014 04:54:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XDrY7-0007BY-Mz for qemu-devel@nongnu.org; Sun, 03 Aug 2014 04:54:04 -0400 Received: from os.inf.tu-dresden.de ([141.76.48.99]:37369) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XDrY7-0007B8-Hw for qemu-devel@nongnu.org; Sun, 03 Aug 2014 04:53:51 -0400 Received: from erwin.inf.tu-dresden.de ([141.76.48.80] helo=x) by os.inf.tu-dresden.de with esmtp (Exim 4.83) id 1XDrY4-000473-JK for qemu-devel@nongnu.org; Sun, 03 Aug 2014 10:53:48 +0200 From: Adam Lackorzynski Date: Sun, 3 Aug 2014 10:53:46 +0200 Message-Id: <1407056027-7522-3-git-send-email-adam@os.inf.tu-dresden.de> In-Reply-To: <1407056027-7522-1-git-send-email-adam@os.inf.tu-dresden.de> References: <1407056027-7522-1-git-send-email-adam@os.inf.tu-dresden.de> Subject: [Qemu-devel] [PATCH 2/3] arm_gic: SGIs for GICD_ICFGR are WI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Writes to SGIs for GICD_ICFGR register must be ignored. Signed-off-by: Adam Lackorzynski --- hw/intc/arm_gic.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/intc/arm_gic.c b/hw/intc/arm_gic.c index d2b1aaf..cd6e6ea 100644 --- a/hw/intc/arm_gic.c +++ b/hw/intc/arm_gic.c @@ -566,10 +566,13 @@ static void gic_dist_writeb(void *opaque, hwaddr offset, } else { GIC_CLEAR_MODEL(irq + i); } - if (value & (2 << (i * 2))) { - GIC_SET_EDGE_TRIGGER(irq + i); - } else { - GIC_CLEAR_EDGE_TRIGGER(irq + i); + /* SGIs are WI */ + if (irq >= 16) { + if (value & (2 << (i * 2))) { + GIC_SET_EDGE_TRIGGER(irq + i); + } else { + GIC_CLEAR_EDGE_TRIGGER(irq + i); + } } } } else if (offset < 0xf10) { -- 2.0.1