From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43937)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1b9rBN-00057T-8z
	for qemu-devel@nongnu.org; Mon, 06 Jun 2016 05:50:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1b9rBI-0000Bn-1b
	for qemu-devel@nongnu.org; Mon, 06 Jun 2016 05:50:52 -0400
Received: from mx6-phx2.redhat.com ([209.132.183.39]:41999)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1b9rBH-0000BV-Pa
	for qemu-devel@nongnu.org; Mon, 06 Jun 2016 05:50:47 -0400
Date: Mon, 6 Jun 2016 05:50:41 -0400 (EDT)
From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau <mlureau@redhat.com>
Message-ID: <1407179122.3562105.1465206641086.JavaMail.zimbra@redhat.com>
In-Reply-To: <20160606090649.GA30154@yliu-dev.sh.intel.com>
References: <1462896240-30999-1-git-send-email-marcandre.lureau@redhat.com>
	<1462896240-30999-8-git-send-email-marcandre.lureau@redhat.com>
	<20160606090649.GA30154@yliu-dev.sh.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 07/10] vhost-net: save & restore vhost-user
 acked features
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: marcandre lureau <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org, "Michael S . Tsirkin" <mst@redhat.com>, Ilya Maximets <i.maximets@samsung.com>, jonshin@cisco.com, Tetsuya Mukawa <mukawa@igel.co.jp>

Hi

----- Original Message -----
> > +uint64_t vhost_net_get_acked_features(VHostNetState *net)
> > +{
> > +    return net->dev.acked_features;
> > +}
> 
> Note that you need add a dummy implementation for !VHOST_NET. Otherwise,
> build won't work.

good catch, fixed.

> And sorry for being noisy, here is another ping about the status of
> this patch set.

thanks