qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: famz@redhat.com, Markus Armbruster <armbru@redhat.com>,
	wenchaoqemu@gmail.com, Luiz Capitulino <lcapitulino@redhat.com>
Subject: [Qemu-devel] [PATCH 0/7] drop qapi nested structs
Date: Mon,  4 Aug 2014 22:36:04 -0600	[thread overview]
Message-ID: <1407213371-7408-1-git-send-email-eblake@redhat.com> (raw)

According to this email:
https://lists.gnu.org/archive/html/qemu-devel/2014-05/msg00708.html
we want to repurpose 'data': { 'name': {dict...} } in qapi files
for future use of designating default values of optional parameters.
But to do that, we must first nuke existing use of that syntax for
declaring nested structs.  Enhancing the testsuite while at it
never hurts.

Eric Blake (7):
  qapi: add some enum tests
  qapi: better error message for bad enum
  qapi: merge UserDefTwo and UserDefNested in tests
  qapi: drop tests for inline subtypes
  qapi: drop inline subtype in query-version
  qapi: drop inline subtype in query-pci
  qapi: drop support for inline subtypes

 hmp.c                                        | 28 ++++-----
 hw/pci/pci.c                                 | 42 +++++++------
 qapi-schema.json                             | 90 +++++++++++++++++++---------
 qapi/common.json                             | 26 +++++---
 qmp.c                                        |  9 +--
 scripts/qapi-commands.py                     |  8 +--
 scripts/qapi-event.py                        |  4 +-
 scripts/qapi-types.py                        |  9 +--
 scripts/qapi-visit.py                        | 37 ++----------
 scripts/qapi.py                              | 52 ++++++++++------
 tests/Makefile                               |  6 +-
 tests/qapi-schema/enum-empty.err             |  0
 tests/qapi-schema/enum-empty.exit            |  1 +
 tests/qapi-schema/enum-empty.json            |  1 +
 tests/qapi-schema/enum-empty.out             |  3 +
 tests/qapi-schema/enum-missing-data.err      |  1 +
 tests/qapi-schema/enum-missing-data.exit     |  1 +
 tests/qapi-schema/enum-missing-data.json     |  1 +
 tests/qapi-schema/enum-missing-data.out      |  0
 tests/qapi-schema/enum-wrong-data.err        |  1 +
 tests/qapi-schema/enum-wrong-data.exit       |  1 +
 tests/qapi-schema/enum-wrong-data.json       |  1 +
 tests/qapi-schema/enum-wrong-data.out        |  0
 tests/qapi-schema/event-nest-struct.err      |  2 +-
 tests/qapi-schema/nested-struct-data.err     |  1 +
 tests/qapi-schema/nested-struct-data.exit    |  1 +
 tests/qapi-schema/nested-struct-data.json    |  3 +
 tests/qapi-schema/nested-struct-data.out     |  0
 tests/qapi-schema/nested-struct-returns.err  |  1 +
 tests/qapi-schema/nested-struct-returns.exit |  1 +
 tests/qapi-schema/nested-struct-returns.json |  2 +
 tests/qapi-schema/nested-struct-returns.out  |  0
 tests/qapi-schema/qapi-schema-test.json      | 18 +++---
 tests/qapi-schema/qapi-schema-test.out       | 10 ++--
 tests/test-qmp-commands.c                    | 35 ++++++-----
 tests/test-qmp-input-strict.c                | 19 +++---
 tests/test-qmp-input-visitor.c               | 25 ++++----
 tests/test-qmp-output-visitor.c              | 64 +++++++++++---------
 tests/test-visitor-serialization.c           | 84 ++++++++++++++------------
 39 files changed, 334 insertions(+), 254 deletions(-)
 create mode 100644 tests/qapi-schema/enum-empty.err
 create mode 100644 tests/qapi-schema/enum-empty.exit
 create mode 100644 tests/qapi-schema/enum-empty.json
 create mode 100644 tests/qapi-schema/enum-empty.out
 create mode 100644 tests/qapi-schema/enum-missing-data.err
 create mode 100644 tests/qapi-schema/enum-missing-data.exit
 create mode 100644 tests/qapi-schema/enum-missing-data.json
 create mode 100644 tests/qapi-schema/enum-missing-data.out
 create mode 100644 tests/qapi-schema/enum-wrong-data.err
 create mode 100644 tests/qapi-schema/enum-wrong-data.exit
 create mode 100644 tests/qapi-schema/enum-wrong-data.json
 create mode 100644 tests/qapi-schema/enum-wrong-data.out
 create mode 100644 tests/qapi-schema/nested-struct-data.err
 create mode 100644 tests/qapi-schema/nested-struct-data.exit
 create mode 100644 tests/qapi-schema/nested-struct-data.json
 create mode 100644 tests/qapi-schema/nested-struct-data.out
 create mode 100644 tests/qapi-schema/nested-struct-returns.err
 create mode 100644 tests/qapi-schema/nested-struct-returns.exit
 create mode 100644 tests/qapi-schema/nested-struct-returns.json
 create mode 100644 tests/qapi-schema/nested-struct-returns.out

-- 
1.9.3

             reply	other threads:[~2014-08-05  4:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-05  4:36 Eric Blake [this message]
2014-08-05  4:36 ` [Qemu-devel] [PATCH 1/7] qapi: add some enum tests Eric Blake
2014-08-05  5:31   ` Fam Zheng
2014-08-05  4:36 ` [Qemu-devel] [PATCH 2/7] qapi: better error message for bad enum Eric Blake
2014-08-05  4:36 ` [Qemu-devel] [PATCH 3/7] qapi: merge UserDefTwo and UserDefNested in tests Eric Blake
2014-08-05  4:36 ` [Qemu-devel] [PATCH 4/7] qapi: drop tests for inline subtypes Eric Blake
2014-08-05  4:36 ` [Qemu-devel] [PATCH 5/7] qapi: drop inline subtype in query-version Eric Blake
2014-08-05  4:36 ` [Qemu-devel] [PATCH 6/7] qapi: drop inline subtype in query-pci Eric Blake
2014-08-05  4:36 ` [Qemu-devel] [PATCH 7/7] qapi: drop support for inline subtypes Eric Blake
2014-08-05  6:04   ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1407213371-7408-1-git-send-email-eblake@redhat.com \
    --to=eblake@redhat.com \
    --cc=armbru@redhat.com \
    --cc=famz@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=wenchaoqemu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).