From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39375) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEamW-00006R-7i for qemu-devel@nongnu.org; Tue, 05 Aug 2014 05:11:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XEamQ-0002w8-39 for qemu-devel@nongnu.org; Tue, 05 Aug 2014 05:11:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6510) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEamP-0002vx-Rl for qemu-devel@nongnu.org; Tue, 05 Aug 2014 05:11:38 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s759BZvJ014134 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 5 Aug 2014 05:11:36 -0400 From: Fam Zheng Date: Tue, 5 Aug 2014 17:11:51 +0800 Message-Id: <1407229913-16862-1-git-send-email-famz@redhat.com> Subject: [Qemu-devel] [PATCH 0/2] scsi: Change device init to realize List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, armbru@redhat.com, stefanha@redhat.com DeviceClass->init is the old interface, let's convert scsi devices to the new ->realize API. A user visible change is the error message shown in qemu-iotests reference output, but I don't know what's the best way to retain it. So please review if and how this could be improved. Fam Fam Zheng (2): block: Pass errp in blkconf_geometry scsi-bus: Convert DeviceClass init to realize hw/block/block.c | 18 +++++----- hw/block/virtio-blk.c | 7 ++-- hw/ide/qdev.c | 11 ++++-- hw/scsi/lsi53c895a.c | 2 ++ hw/scsi/scsi-bus.c | 64 +++++++++++++++++------------------ hw/scsi/scsi-disk.c | 83 +++++++++++++++++++++++++--------------------- hw/scsi/scsi-generic.c | 37 ++++++++++----------- include/hw/block/block.h | 6 ++-- include/hw/scsi/scsi.h | 7 ++-- tests/qemu-iotests/051.out | 4 +-- 10 files changed, 125 insertions(+), 114 deletions(-) -- 2.0.3