From: zhanghailiang <zhang.zhanghailiang@huawei.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@redhat.com, mst@redhat.com,
luonengjun@huawei.com, peter.huangpeng@huawei.com,
lcapitulino@redhat.com, alex@alex.org.uk, pbonzini@redhat.com,
alex.bennee@linaro.org,
zhanghailiang <zhang.zhanghailiang@huawei.com>
Subject: [Qemu-devel] [PATCH v2 3/4] virtio-blk: fix reference a pointer which might be freed
Date: Wed, 6 Aug 2014 14:15:57 +0800 [thread overview]
Message-ID: <1407305758-13108-4-git-send-email-zhang.zhanghailiang@huawei.com> (raw)
In-Reply-To: <1407305758-13108-1-git-send-email-zhang.zhanghailiang@huawei.com>
In function virtio_blk_handle_request, it may freed memory pointed by req,
So do not access member of req after calling this function.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
---
hw/block/virtio-blk.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index c241c50..54a853a 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -458,7 +458,7 @@ static void virtio_blk_handle_output(VirtIODevice *vdev, VirtQueue *vq)
static void virtio_blk_dma_restart_bh(void *opaque)
{
VirtIOBlock *s = opaque;
- VirtIOBlockReq *req = s->rq;
+ VirtIOBlockReq *req = s->rq, *next = NULL;
MultiReqBuffer mrb = {
.num_writes = 0,
};
@@ -469,8 +469,9 @@ static void virtio_blk_dma_restart_bh(void *opaque)
s->rq = NULL;
while (req) {
+ next = req->next;
virtio_blk_handle_request(req, &mrb);
- req = req->next;
+ req = next;
}
virtio_submit_multiwrite(s->bs, &mrb);
--
1.7.12.4
next prev parent reply other threads:[~2014-08-06 6:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 6:15 [Qemu-devel] [PATCH v2 0/4] fix several bugs about use-after-free and an api abuse zhanghailiang
2014-08-06 6:15 ` [Qemu-devel] [PATCH v2 1/4] l2cap: fix access freed memory zhanghailiang
2014-08-06 6:15 ` [Qemu-devel] [PATCH v2 2/4] monitor: " zhanghailiang
2014-08-06 6:15 ` zhanghailiang [this message]
2014-08-06 6:15 ` [Qemu-devel] [PATCH v2 4/4] ivshmem: check the value returned by fstat() zhanghailiang
2014-08-06 12:30 ` Levente Kurusa
2014-08-07 1:50 ` zhanghailiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407305758-13108-4-git-send-email-zhang.zhanghailiang@huawei.com \
--to=zhang.zhanghailiang@huawei.com \
--cc=alex.bennee@linaro.org \
--cc=alex@alex.org.uk \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=luonengjun@huawei.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).