From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40345) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEuWo-000556-3q for qemu-devel@nongnu.org; Wed, 06 Aug 2014 02:16:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XEuWi-0006Jx-Cu for qemu-devel@nongnu.org; Wed, 06 Aug 2014 02:16:50 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:13882) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEuWh-0006It-Hx for qemu-devel@nongnu.org; Wed, 06 Aug 2014 02:16:44 -0400 From: zhanghailiang Date: Wed, 6 Aug 2014 14:15:58 +0800 Message-ID: <1407305758-13108-5-git-send-email-zhang.zhanghailiang@huawei.com> In-Reply-To: <1407305758-13108-1-git-send-email-zhang.zhanghailiang@huawei.com> References: <1407305758-13108-1-git-send-email-zhang.zhanghailiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH v2 4/4] ivshmem: check the value returned by fstat() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com, mst@redhat.com, luonengjun@huawei.com, peter.huangpeng@huawei.com, lcapitulino@redhat.com, alex@alex.org.uk, pbonzini@redhat.com, alex.bennee@linaro.org, zhanghailiang The function fstat() may fail, so check its return value. Signed-off-by: zhanghailiang --- hw/misc/ivshmem.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 768e528..5d939d2 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -324,7 +324,11 @@ static int check_shm_size(IVShmemState *s, int fd) { struct stat buf; - fstat(fd, &buf); + if (fstat(fd, &buf) < 0) { + fprintf(stderr, "ivshmem: exiting for fstat fd '%d' failed: %s\n", + fd, strerror(errno)); + return -1; + } if (s->ivshmem_size > buf.st_size) { fprintf(stderr, -- 1.7.12.4