From: Tiejun Chen <tiejun.chen@intel.com>
To: mst@redhat.com
Cc: pbonzini@redhat.com, xen-devel@lists.xensource.com,
qemu-devel@nongnu.org, stefano.stabellini@eu.citrix.com
Subject: [Qemu-devel] [v4][PATCH 3/5] I440FX_PCI_DEVICE: add pci_type to index
Date: Wed, 6 Aug 2014 14:50:33 +0800 [thread overview]
Message-ID: <1407307835-9692-4-git-send-email-tiejun.chen@intel.com> (raw)
In-Reply-To: <1407307835-9692-1-git-send-email-tiejun.chen@intel.com>
We need to use this index to reuse this macro later
Signed-off-by: Tiejun Chen <tiejun.chen@intel.com>
---
hw/pci-host/piix.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
v4:
* New patch to extend I440FX_PCI_DEVICE
diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
index 0cd82b8..4330599 100644
--- a/hw/pci-host/piix.c
+++ b/hw/pci-host/piix.c
@@ -90,8 +90,8 @@ typedef struct PIIX3State {
MemoryRegion rcr_mem;
} PIIX3State;
-#define I440FX_PCI_DEVICE(obj) \
- OBJECT_CHECK(PCII440FXState, (obj), TYPE_I440FX_PCI_DEVICE)
+#define I440FX_PCI_DEVICE(obj, type) \
+ OBJECT_CHECK(PCII440FXState, (obj), type)
struct PCII440FXState {
/*< private >*/
@@ -155,7 +155,7 @@ static void i440fx_set_smm(int val, void *arg)
static void i440fx_write_config(PCIDevice *dev,
uint32_t address, uint32_t val, int len)
{
- PCII440FXState *d = I440FX_PCI_DEVICE(dev);
+ PCII440FXState *d = I440FX_PCI_DEVICE(dev, TYPE_I440FX_PCI_DEVICE);
/* XXX: implement SMRAM.D_LOCK */
pci_default_write_config(dev, address, val, len);
@@ -295,7 +295,7 @@ static void i440fx_pcihost_realize(DeviceState *dev, Error **errp)
static int i440fx_initfn(PCIDevice *dev)
{
- PCII440FXState *d = I440FX_PCI_DEVICE(dev);
+ PCII440FXState *d = I440FX_PCI_DEVICE(dev, TYPE_I440FX_PCI_DEVICE);
dev->config[I440FX_SMRAM] = 0x02;
@@ -333,7 +333,7 @@ PCIBus *i440fx_init(const char *host_type, const char *pci_type,
qdev_init_nofail(dev);
d = pci_create_simple(b, 0, pci_type);
- *pi440fx_state = I440FX_PCI_DEVICE(d);
+ *pi440fx_state = I440FX_PCI_DEVICE(d, pci_type);
f = *pi440fx_state;
f->system_memory = address_space_mem;
f->pci_address_space = pci_address_space;
--
1.9.1
next prev parent reply other threads:[~2014-08-06 6:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 6:50 [Qemu-devel] [v4][PATCH 0/5] xen: introduce new machine for IGD passthrough Tiejun Chen
2014-08-06 6:50 ` [Qemu-devel] [v4][PATCH 1/5] i440fx: make types configurable at run-time Tiejun Chen
2014-08-06 6:50 ` [Qemu-devel] [v4][PATCH 2/5] pc_init1: pass parameters just with types Tiejun Chen
2014-08-06 6:50 ` Tiejun Chen [this message]
2014-08-06 9:45 ` [Qemu-devel] [v4][PATCH 3/5] I440FX_PCI_DEVICE: add pci_type to index Michael S. Tsirkin
2014-08-06 10:17 ` Chen, Tiejun
2014-08-06 21:07 ` Michael S. Tsirkin
2014-08-07 1:40 ` Chen, Tiejun
2014-08-10 20:27 ` Michael S. Tsirkin
2014-08-11 2:50 ` Chen, Tiejun
2014-08-12 8:54 ` Michael S. Tsirkin
2014-08-12 9:25 ` Chen, Tiejun
2014-08-12 9:39 ` Chen, Tiejun
2014-08-06 6:50 ` [Qemu-devel] [v4][PATCH 4/5] xen:hw:pci-host:piix: create host bridge to passthrough Tiejun Chen
2014-08-06 9:42 ` Michael S. Tsirkin
2014-08-06 9:47 ` Chen, Tiejun
2014-08-06 21:04 ` Michael S. Tsirkin
2014-08-07 1:44 ` Chen, Tiejun
2014-08-06 6:50 ` [Qemu-devel] [v4][PATCH 5/5] xen:hw:i386:pc_piix: introduce new machine for IGD passthrough Tiejun Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407307835-9692-4-git-send-email-tiejun.chen@intel.com \
--to=tiejun.chen@intel.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).