qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Amos Kong <akong@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	Anthony Liguori <aliguori@amazon.com>
Subject: [Qemu-devel] [PATCH RESEND 1/2] rng-egd: Free old chr_name value before setting new one
Date: Wed,  6 Aug 2014 15:18:20 -0300	[thread overview]
Message-ID: <1407349101-27793-2-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1407349101-27793-1-git-send-email-ehabkost@redhat.com>

Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 backends/rng-egd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/backends/rng-egd.c b/backends/rng-egd.c
index 25bb3b4..2962795 100644
--- a/backends/rng-egd.c
+++ b/backends/rng-egd.c
@@ -169,6 +169,7 @@ static void rng_egd_set_chardev(Object *obj, const char *value, Error **errp)
     if (b->opened) {
         error_set(errp, QERR_PERMISSION_DENIED);
     } else {
+        g_free(s->chr_name);
         s->chr_name = g_strdup(value);
     }
 }
-- 
1.9.3

  reply	other threads:[~2014-08-06 18:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-06 18:18 [Qemu-devel] [PATCH RESEND 0/2] Fix leaks on object_property_add_str() setters Eduardo Habkost
2014-08-06 18:18 ` Eduardo Habkost [this message]
2014-08-07  2:24   ` [Qemu-devel] [PATCH RESEND 1/2] rng-egd: Free old chr_name value before setting new one Amos Kong
2014-08-07 10:18     ` Paolo Bonzini
2014-08-25 15:59       ` Amos Kong
2014-08-06 18:18 ` [Qemu-devel] [PATCH RESEND 2/2] hw/machine: Free old values of string properties Eduardo Habkost
2014-08-07  2:24   ` Amos Kong
2014-09-04 15:25   ` Michael S. Tsirkin
2014-08-22 19:35 ` [Qemu-devel] [PATCH RESEND 0/2] Fix leaks on object_property_add_str() setters Eduardo Habkost
2014-08-24 11:16   ` Michael S. Tsirkin
2014-08-25 11:44     ` Paolo Bonzini
2014-09-04 15:08       ` Eduardo Habkost
2014-09-04 15:29         ` Michael S. Tsirkin
2014-09-04 15:31           ` Michael S. Tsirkin
2014-09-04 15:34           ` Eduardo Habkost
2014-09-04 16:11             ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1407349101-27793-2-git-send-email-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=akong@redhat.com \
    --cc=aliguori@amazon.com \
    --cc=armbru@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).