From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38412) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XF83M-0000Rv-6l for qemu-devel@nongnu.org; Wed, 06 Aug 2014 16:43:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XF830-0005Mn-JA for qemu-devel@nongnu.org; Wed, 06 Aug 2014 16:43:20 -0400 Received: from e34.co.us.ibm.com ([32.97.110.152]:50930) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XF830-0005MT-D2 for qemu-devel@nongnu.org; Wed, 06 Aug 2014 16:42:58 -0400 Received: from /spool/local by e34.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 6 Aug 2014 14:42:57 -0600 From: Michael Roth Date: Wed, 6 Aug 2014 15:39:12 -0500 Message-Id: <1407357598-21541-63-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1407357598-21541-1-git-send-email-mdroth@linux.vnet.ibm.com> References: <1407357598-21541-1-git-send-email-mdroth@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 062/108] block: Plug memory leak on brv_open_image() error path List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org From: Markus Armbruster Introduced in commit da557a. Spotted by Coverity. Signed-off-by: Markus Armbruster Reviewed-by: Benoit Canet Signed-off-by: Kevin Wolf (cherry picked from commit b20e61e0d52eef57cf5db55087b16e0b5207e730) Signed-off-by: Michael Roth --- block.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block.c b/block.c index e3ba203..5448430 100644 --- a/block.c +++ b/block.c @@ -1158,6 +1158,7 @@ int bdrv_open_image(BlockDriverState **pbs, const char *filename, bdref_key); ret = -EINVAL; } + QDECREF(image_options); goto done; } -- 1.9.1