qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: zhanghailiang <zhang.zhanghailiang@huawei.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, lkurusa@redhat.com,
	zhanghailiang <zhang.zhanghailiang@huawei.com>,
	mst@redhat.com, jan.kiszka@siemens.com, riku.voipio@iki.fi,
	mjt@tls.msk.ru, peter.huangpeng@huawei.com,
	lcapitulino@redhat.com, stefanha@redhat.com,
	Li Liu <john.liuli@huawei.com>,
	luonengjun@huawei.com, pbonzini@redhat.com,
	alex.bennee@linaro.org, rth@twiddle.net
Subject: [Qemu-devel] [PATCH v3 08/10] qtest: check the value returned by fopen()
Date: Thu, 7 Aug 2014 16:01:50 +0800	[thread overview]
Message-ID: <1407398512-20780-9-git-send-email-zhang.zhanghailiang@huawei.com> (raw)
In-Reply-To: <1407398512-20780-1-git-send-email-zhang.zhanghailiang@huawei.com>

The function fopen() may fail, so check its return value.

Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
Signed-off-by: Li Liu <john.liuli@huawei.com>
---
 qtest.c                  | 5 +++++
 tests/bios-tables-test.c | 2 ++
 2 files changed, 7 insertions(+)

diff --git a/qtest.c b/qtest.c
index 04a6dc1..ae9b636 100644
--- a/qtest.c
+++ b/qtest.c
@@ -536,6 +536,11 @@ void qtest_init(const char *qtest_chrdev, const char *qtest_log, Error **errp)
     if (qtest_log) {
         if (strcmp(qtest_log, "none") != 0) {
             qtest_log_fp = fopen(qtest_log, "w+");
+            if (qtest_log_fp == NULL) {
+                error_setg(errp, "Failed to open log file for qtest: \"%s\"",
+                           qtest_log);
+                return;
+            }
         }
     } else {
         qtest_log_fp = stderr;
diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c
index 045eb27..6a357c0 100644
--- a/tests/bios-tables-test.c
+++ b/tests/bios-tables-test.c
@@ -790,6 +790,8 @@ int main(int argc, char *argv[])
     const char *arch = qtest_get_arch();
     FILE *f = fopen(disk, "w");
     int ret;
+
+    g_assert(f != NULL);
     fwrite(boot_sector, 1, sizeof boot_sector, f);
     fclose(f);
 
-- 
1.7.12.4

  parent reply	other threads:[~2014-08-07  8:04 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-07  8:01 [Qemu-devel] [PATCH v3 00/10] fix three bugs about use-after-free and several api abuse zhanghailiang
2014-08-07  8:01 ` [Qemu-devel] [PATCH v3 01/10] l2cap: fix access freed memory zhanghailiang
2014-08-07  8:01 ` [Qemu-devel] [PATCH v3 02/10] monitor: " zhanghailiang
2014-08-07 11:01   ` Gonglei (Arei)
2014-08-07  8:01 ` [Qemu-devel] [PATCH v3 03/10] virtio-blk: fix reference a pointer which might be freed zhanghailiang
2014-08-07  8:01 ` [Qemu-devel] [PATCH v3 04/10] ivshmem: check the value returned by fstat() zhanghailiang
2014-08-07  8:53   ` Levente Kurusa
2014-08-07  8:01 ` [Qemu-devel] [PATCH v3 05/10] util/path: check return value of malloc() zhanghailiang
2014-08-07 11:04   ` Gonglei (Arei)
2014-08-07  8:01 ` [Qemu-devel] [PATCH v3 06/10] slirp: " zhanghailiang
2014-08-07 11:08   ` Gonglei (Arei)
2014-08-07 11:25     ` zhanghailiang
2014-08-07  8:01 ` [Qemu-devel] [PATCH v3 07/10] linux-user: " zhanghailiang
2014-08-07 17:19   ` Richard Henderson
2014-08-08  1:21     ` zhanghailiang
2014-08-07  8:01 ` zhanghailiang [this message]
2014-08-07 11:14   ` [Qemu-devel] [PATCH v3 08/10] qtest: check the value returned by fopen() Gonglei (Arei)
2014-08-07 11:33     ` zhanghailiang
2014-08-07  8:01 ` [Qemu-devel] [PATCH v3 09/10] tcg: check return value of fopen() zhanghailiang
2014-08-07  8:01 ` [Qemu-devel] [PATCH v3 10/10] block/vvfat: fix setbuf stream parameter may be NULL zhanghailiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1407398512-20780-9-git-send-email-zhang.zhanghailiang@huawei.com \
    --to=zhang.zhanghailiang@huawei.com \
    --cc=alex.bennee@linaro.org \
    --cc=jan.kiszka@siemens.com \
    --cc=john.liuli@huawei.com \
    --cc=kwolf@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=lkurusa@redhat.com \
    --cc=luonengjun@huawei.com \
    --cc=mjt@tls.msk.ru \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.huangpeng@huawei.com \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    --cc=rth@twiddle.net \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).