From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50365) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFIg3-00014o-7a for qemu-devel@nongnu.org; Thu, 07 Aug 2014 04:04:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XFIfu-0004yH-SE for qemu-devel@nongnu.org; Thu, 07 Aug 2014 04:03:59 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:5823) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFIfs-0004wy-Qz for qemu-devel@nongnu.org; Thu, 07 Aug 2014 04:03:50 -0400 From: zhanghailiang Date: Thu, 7 Aug 2014 16:01:50 +0800 Message-ID: <1407398512-20780-9-git-send-email-zhang.zhanghailiang@huawei.com> In-Reply-To: <1407398512-20780-1-git-send-email-zhang.zhanghailiang@huawei.com> References: <1407398512-20780-1-git-send-email-zhang.zhanghailiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH v3 08/10] qtest: check the value returned by fopen() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, lkurusa@redhat.com, zhanghailiang , mst@redhat.com, jan.kiszka@siemens.com, riku.voipio@iki.fi, mjt@tls.msk.ru, peter.huangpeng@huawei.com, lcapitulino@redhat.com, stefanha@redhat.com, Li Liu , luonengjun@huawei.com, pbonzini@redhat.com, alex.bennee@linaro.org, rth@twiddle.net The function fopen() may fail, so check its return value. Signed-off-by: zhanghailiang Signed-off-by: Li Liu --- qtest.c | 5 +++++ tests/bios-tables-test.c | 2 ++ 2 files changed, 7 insertions(+) diff --git a/qtest.c b/qtest.c index 04a6dc1..ae9b636 100644 --- a/qtest.c +++ b/qtest.c @@ -536,6 +536,11 @@ void qtest_init(const char *qtest_chrdev, const char *qtest_log, Error **errp) if (qtest_log) { if (strcmp(qtest_log, "none") != 0) { qtest_log_fp = fopen(qtest_log, "w+"); + if (qtest_log_fp == NULL) { + error_setg(errp, "Failed to open log file for qtest: \"%s\"", + qtest_log); + return; + } } } else { qtest_log_fp = stderr; diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c index 045eb27..6a357c0 100644 --- a/tests/bios-tables-test.c +++ b/tests/bios-tables-test.c @@ -790,6 +790,8 @@ int main(int argc, char *argv[]) const char *arch = qtest_get_arch(); FILE *f = fopen(disk, "w"); int ret; + + g_assert(f != NULL); fwrite(boot_sector, 1, sizeof boot_sector, f); fclose(f); -- 1.7.12.4