From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51471) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFgQj-000637-7b for qemu-devel@nongnu.org; Fri, 08 Aug 2014 05:25:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XFgQd-0005no-4J for qemu-devel@nongnu.org; Fri, 08 Aug 2014 05:25:45 -0400 Received: from szxga01-in.huawei.com ([119.145.14.64]:56681) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFgQc-0005mH-A5 for qemu-devel@nongnu.org; Fri, 08 Aug 2014 05:25:39 -0400 From: zhanghailiang Date: Fri, 8 Aug 2014 17:21:12 +0800 Message-ID: <1407489672-12212-11-git-send-email-zhang.zhanghailiang@huawei.com> In-Reply-To: <1407489672-12212-1-git-send-email-zhang.zhanghailiang@huawei.com> References: <1407489672-12212-1-git-send-email-zhang.zhanghailiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH v4 10/10] block/vvfat: fix setbuf stream parameter may be NULL List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, lkurusa@redhat.com, zhanghailiang , mst@redhat.com, jan.kiszka@siemens.com, riku.voipio@iki.fi, mjt@tls.msk.ru, peter.huangpeng@huawei.com, lcapitulino@redhat.com, stefanha@redhat.com, Li Liu , luonengjun@huawei.com, pbonzini@redhat.com, alex.bennee@linaro.org, rth@twiddle.net From: Li Liu fopen() may return NULL which will cause setbuf() segmentfault Signed-off-by: zhanghailiang Signed-off-by: Li Liu --- block/vvfat.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/block/vvfat.c b/block/vvfat.c index 70176b1..6889ea9 100644 --- a/block/vvfat.c +++ b/block/vvfat.c @@ -1084,7 +1084,10 @@ static int vvfat_open(BlockDriverState *bs, QDict *options, int flags, DLOG(if (stderr == NULL) { stderr = fopen("vvfat.log", "a"); - setbuf(stderr, NULL); + + if (stderr) { + setbuf(stderr, NULL); + } }) opts = qemu_opts_create(&runtime_opts, NULL, 0, &error_abort); -- 1.7.12.4