qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: zhanghailiang <zhang.zhanghailiang@huawei.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, lkurusa@redhat.com,
	zhanghailiang <zhang.zhanghailiang@huawei.com>,
	mst@redhat.com, jan.kiszka@siemens.com, riku.voipio@iki.fi,
	mjt@tls.msk.ru, peter.huangpeng@huawei.com,
	lcapitulino@redhat.com, stefanha@redhat.com,
	luonengjun@huawei.com, pbonzini@redhat.com,
	alex.bennee@linaro.org, rth@twiddle.net
Subject: [Qemu-devel] [PATCH v4 06/10] slirp/misc: check return value of malloc()
Date: Fri, 8 Aug 2014 17:21:08 +0800	[thread overview]
Message-ID: <1407489672-12212-7-git-send-email-zhang.zhanghailiang@huawei.com> (raw)
In-Reply-To: <1407489672-12212-1-git-send-email-zhang.zhanghailiang@huawei.com>

Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
---
 slirp/misc.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/slirp/misc.c b/slirp/misc.c
index b8eb74c..9b457ad 100644
--- a/slirp/misc.c
+++ b/slirp/misc.c
@@ -55,6 +55,10 @@ int add_exec(struct ex_list **ex_ptr, int do_pty, char *exec,
 
 	tmp_ptr = *ex_ptr;
 	*ex_ptr = (struct ex_list *)malloc(sizeof(struct ex_list));
+    if (*ex_ptr == NULL) {
+        fprintf(stderr, "Error: malloc failed\n");
+        return -1;
+    }
 	(*ex_ptr)->ex_fport = port;
 	(*ex_ptr)->ex_addr = addr;
 	(*ex_ptr)->ex_pty = do_pty;
@@ -236,8 +240,9 @@ strdup(str)
 	char *bptr;
 
 	bptr = (char *)malloc(strlen(str)+1);
-	strcpy(bptr, str);
-
+    if (bptr) {
+        strcpy(bptr, str);
+    }
 	return bptr;
 }
 #endif
-- 
1.7.12.4

  parent reply	other threads:[~2014-08-08  9:23 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-08  9:21 [Qemu-devel] [PATCH v4 00/10] fix three bugs about use-after-free and several api abuse zhanghailiang
2014-08-08  9:21 ` [Qemu-devel] [PATCH v4 01/10] l2cap: fix access freed memory zhanghailiang
2014-08-08  9:21 ` [Qemu-devel] [PATCH v4 02/10] monitor: " zhanghailiang
2014-08-08  9:21 ` [Qemu-devel] [PATCH v4 03/10] virtio-blk: fix reference a pointer which might be freed zhanghailiang
2014-08-08  9:21 ` [Qemu-devel] [PATCH v4 04/10] ivshmem: check the value returned by fstat() zhanghailiang
2014-08-08  9:21 ` [Qemu-devel] [PATCH v4 05/10] util/path: check return value of malloc() zhanghailiang
2014-08-08  9:36   ` Alex Bennée
2014-08-08 10:35     ` zhanghailiang
2014-08-08  9:21 ` zhanghailiang [this message]
2014-08-08  9:43   ` [Qemu-devel] [PATCH v4 06/10] slirp/misc: " Alex Bennée
2014-08-08 10:44     ` zhanghailiang
2014-08-08 13:24       ` Alex Bennée
2014-08-11  7:18         ` zhanghailiang
2014-08-08  9:21 ` [Qemu-devel] [PATCH v4 07/10] linux-user: " zhanghailiang
2014-08-08  9:21 ` [Qemu-devel] [PATCH v4 08/10] tests/bios-tables-test: check the value returned by fopen() zhanghailiang
2014-08-08  9:51   ` Alex Bennée
2014-08-08 10:46     ` zhanghailiang
2014-08-08  9:21 ` [Qemu-devel] [PATCH v4 09/10] tcg: check return value of fopen() zhanghailiang
2014-08-08  9:21 ` [Qemu-devel] [PATCH v4 10/10] block/vvfat: fix setbuf stream parameter may be NULL zhanghailiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1407489672-12212-7-git-send-email-zhang.zhanghailiang@huawei.com \
    --to=zhang.zhanghailiang@huawei.com \
    --cc=alex.bennee@linaro.org \
    --cc=jan.kiszka@siemens.com \
    --cc=kwolf@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=lkurusa@redhat.com \
    --cc=luonengjun@huawei.com \
    --cc=mjt@tls.msk.ru \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.huangpeng@huawei.com \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    --cc=rth@twiddle.net \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).