From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50598) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFgO3-00016E-7f for qemu-devel@nongnu.org; Fri, 08 Aug 2014 05:23:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XFgNv-0004s3-00 for qemu-devel@nongnu.org; Fri, 08 Aug 2014 05:22:59 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:45177) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFgNu-0004re-8A for qemu-devel@nongnu.org; Fri, 08 Aug 2014 05:22:50 -0400 From: zhanghailiang Date: Fri, 8 Aug 2014 17:21:08 +0800 Message-ID: <1407489672-12212-7-git-send-email-zhang.zhanghailiang@huawei.com> In-Reply-To: <1407489672-12212-1-git-send-email-zhang.zhanghailiang@huawei.com> References: <1407489672-12212-1-git-send-email-zhang.zhanghailiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH v4 06/10] slirp/misc: check return value of malloc() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, lkurusa@redhat.com, zhanghailiang , mst@redhat.com, jan.kiszka@siemens.com, riku.voipio@iki.fi, mjt@tls.msk.ru, peter.huangpeng@huawei.com, lcapitulino@redhat.com, stefanha@redhat.com, luonengjun@huawei.com, pbonzini@redhat.com, alex.bennee@linaro.org, rth@twiddle.net Signed-off-by: zhanghailiang --- slirp/misc.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/slirp/misc.c b/slirp/misc.c index b8eb74c..9b457ad 100644 --- a/slirp/misc.c +++ b/slirp/misc.c @@ -55,6 +55,10 @@ int add_exec(struct ex_list **ex_ptr, int do_pty, char *exec, tmp_ptr = *ex_ptr; *ex_ptr = (struct ex_list *)malloc(sizeof(struct ex_list)); + if (*ex_ptr == NULL) { + fprintf(stderr, "Error: malloc failed\n"); + return -1; + } (*ex_ptr)->ex_fport = port; (*ex_ptr)->ex_addr = addr; (*ex_ptr)->ex_pty = do_pty; @@ -236,8 +240,9 @@ strdup(str) char *bptr; bptr = (char *)malloc(strlen(str)+1); - strcpy(bptr, str); - + if (bptr) { + strcpy(bptr, str); + } return bptr; } #endif -- 1.7.12.4