From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43388) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFndd-0002Sw-7O for qemu-devel@nongnu.org; Fri, 08 Aug 2014 13:07:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XFndb-0003iW-W2 for qemu-devel@nongnu.org; Fri, 08 Aug 2014 13:07:33 -0400 Received: from mnementh.archaic.org.uk ([2001:8b0:1d0::1]:48941) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFndb-0003iJ-Pg for qemu-devel@nongnu.org; Fri, 08 Aug 2014 13:07:31 -0400 From: Peter Maydell Date: Fri, 8 Aug 2014 18:07:28 +0100 Message-Id: <1407517649-11257-4-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1407517649-11257-1-git-send-email-peter.maydell@linaro.org> References: <1407517649-11257-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH 3/4] qemu-char: Convert udp char backend to parse/kind List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Gerd Hoffmann , Markus Armbruster Convert the udp char backend to the new style QAPI framework. Signed-off-by: Peter Maydell --- qemu-char.c | 69 +++++++++++++++++++++++++++++++++++++++++++++++-------------- 1 file changed, 54 insertions(+), 15 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index cac7edb..a01ccdc 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2383,20 +2383,6 @@ static CharDriverState *qemu_chr_open_udp_fd(int fd) return chr; } -static CharDriverState *qemu_chr_open_udp(QemuOpts *opts) -{ - Error *local_err = NULL; - int fd = -1; - - fd = inet_dgram_opts(opts, &local_err); - if (fd < 0) { - qerror_report_err(local_err); - error_free(local_err); - return NULL; - } - return qemu_chr_open_udp_fd(fd); -} - /***********************************************************/ /* TCP Net console */ @@ -3449,6 +3435,58 @@ static void qemu_chr_parse_socket(QemuOpts *opts, ChardevBackend *backend, backend->socket->addr = addr; } +static void qemu_chr_parse_udp(QemuOpts *opts, ChardevBackend *backend, + Error **errp) +{ + const char *host = qemu_opt_get(opts, "host"); + const char *port = qemu_opt_get(opts, "port"); + bool ipv4 = qemu_opt_get_bool(opts, "ipv4", 0); + bool ipv6 = qemu_opt_get_bool(opts, "ipv6", 0); + const char *localaddr = qemu_opt_get(opts, "localaddr"); + const char *localport = qemu_opt_get(opts, "localport"); + bool has_local = false; + SocketAddress *addr; + + if (host == NULL || strlen(host) == 0) { + host = "localhost"; + } + if (port == NULL || strlen(port) == 0) { + error_setg(errp, "chardev: udp: remote port not specified"); + return; + } + if (localport == NULL || strlen(localport) == 0) { + localport = "0"; + } else { + has_local = true; + } + if (localaddr == NULL || strlen(localaddr) == 0) { + localaddr = ""; + } else { + has_local = true; + } + + backend->udp = g_new0(ChardevUdp, 1); + + addr = g_new0(SocketAddress, 1); + addr->kind = SOCKET_ADDRESS_KIND_INET; + addr->inet = g_new0(InetSocketAddress, 1); + addr->inet->host = g_strdup(host); + addr->inet->port = g_strdup(port); + addr->inet->has_ipv4 = addr->inet->ipv4 = ipv4; + addr->inet->has_ipv6 = addr->inet->ipv6 = ipv6; + backend->udp->remote = addr; + + if (has_local) { + backend->udp->has_local = true; + addr = g_new0(SocketAddress, 1); + addr->kind = SOCKET_ADDRESS_KIND_INET; + addr->inet = g_new0(InetSocketAddress, 1); + addr->inet->host = g_strdup(localaddr); + addr->inet->port = g_strdup(localport); + backend->udp->local = addr; + } +} + typedef struct CharDriver { const char *name; /* old, pre qapi */ @@ -4139,7 +4177,8 @@ static void register_types(void) register_char_driver_qapi("null", CHARDEV_BACKEND_KIND_NULL, NULL); register_char_driver_qapi("socket", CHARDEV_BACKEND_KIND_SOCKET, qemu_chr_parse_socket); - register_char_driver("udp", qemu_chr_open_udp); + register_char_driver_qapi("udp", CHARDEV_BACKEND_KIND_UDP, + qemu_chr_parse_udp); register_char_driver_qapi("ringbuf", CHARDEV_BACKEND_KIND_RINGBUF, qemu_chr_parse_ringbuf); register_char_driver_qapi("file", CHARDEV_BACKEND_KIND_FILE, -- 1.9.1