[Qemu-devel] [PATCH] Fix OHCI ISO TD state never being written back.

[Qemu-devel] [PATCH] Fix OHCI ISO TD state never being written back.

[Jack Un]

Hi,

Hope i'm doing this right.

There appears to be typo in OHCI with isochronous transfers
resulting in isoch. transfer descriptor state never being written back.
The'put_words' function is in a OR statement hence it is never called.

[Qemu-devel] [PATCH] Fix OHCI ISO TD state never being written back.

[Jack Un]

Signed-off-by: Jack Un <jack.un@gmail.com>
---
 hw/usb/hcd-ohci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c
index 13afdf5..cacf7b0 100644
--- a/hw/usb/hcd-ohci.c
+++ b/hw/usb/hcd-ohci.c
@@ -619,8 +619,8 @@ static inline int ohci_put_td(OHCIState *ohci,
 static inline int ohci_put_iso_td(OHCIState *ohci,
                                   dma_addr_t addr, struct ohci_iso_td *td)
 {
-    return put_dwords(ohci, addr, (uint32_t *)td, 4 ||
-           put_words(ohci, addr + 16, td->offset, 8));
+    return put_dwords(ohci, addr, (uint32_t *)td, 4) ||
+           put_words(ohci, addr + 16, td->offset, 8);
 }
 
 static inline int ohci_put_hcca(OHCIState *ohci,
-- 
2.0.4

Re: [Qemu-devel] [PATCH] Fix OHCI ISO TD state never being written back.

[Gonglei]

Hi,

> Subject: [Qemu-devel] [PATCH] Fix OHCI ISO TD state never being written back.
> 
> Signed-off-by: Jack Un <jack.un@gmail.com>
> ---
>  hw/usb/hcd-ohci.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c
> index 13afdf5..cacf7b0 100644
> --- a/hw/usb/hcd-ohci.c
> +++ b/hw/usb/hcd-ohci.c
> @@ -619,8 +619,8 @@ static inline int ohci_put_td(OHCIState *ohci,
>  static inline int ohci_put_iso_td(OHCIState *ohci,
>                                    dma_addr_t addr, struct
> ohci_iso_td *td)
>  {
> -    return put_dwords(ohci, addr, (uint32_t *)td, 4 ||
> -           put_words(ohci, addr + 16, td->offset, 8));
> +    return put_dwords(ohci, addr, (uint32_t *)td, 4) ||
> +           put_words(ohci, addr + 16, td->offset, 8);
>  }
> 
>  static inline int ohci_put_hcca(OHCIState *ohci,
> --
> 2.0.4
> 
Good catch. You can post a patch attaching a good commit message.

Follow the rule please:

http://wiki.qemu.org/Contribute/SubmitAPatch

Best regards,
-Gonglei

Re: [Qemu-devel] [PATCH] Fix OHCI ISO TD state never being written back.

[Gerd Hoffmann]

On Sa, 2014-08-09 at 23:34 +0300, Jack Un wrote:
> Hi,
> 
> Hope i'm doing this right.

Almost.

> There appears to be typo in OHCI with isochronous transfers
> resulting in isoch. transfer descriptor state never being written back.
> The'put_words' function is in a OR statement hence it is never called.

This patch description should go into the commit message of the patch so
it doesn't get lost when applying the patch.  You also don't need a
cover letter for single patches then, just 'git send-email' the patch
as-is.

No need to resend, I've fixed it up this time. Patch added to usb queue.

thanks,
  Gerd