From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pbonzini@redhat.com, armbru@redhat.com,
stefanha@redhat.com
Subject: [Qemu-devel] [PATCH v3 0/2] scsi: Change device init to realize
Date: Mon, 11 Aug 2014 16:45:16 +0800 [thread overview]
Message-ID: <1407746718-16527-1-git-send-email-famz@redhat.com> (raw)
v3: Fix error handling of scsi_device_init (Kevin)
Thanks for reviewing!
DeviceClass->init is the old interface, let's convert scsi devices to the new
->realize API.
A user visible change is the error message shown in qemu-iotests reference
output, but I don't know what's the best way to retain it. So please review if
and how this could be improved.
Fam
Fam Zheng (2):
block: Pass errp in blkconf_geometry
scsi-bus: Convert DeviceClass init to realize
hw/block/block.c | 18 +++++-----
hw/block/virtio-blk.c | 7 ++--
hw/ide/qdev.c | 11 ++++--
hw/scsi/lsi53c895a.c | 2 ++
hw/scsi/scsi-bus.c | 69 ++++++++++++++++++--------------------
hw/scsi/scsi-disk.c | 83 +++++++++++++++++++++++++---------------------
hw/scsi/scsi-generic.c | 37 ++++++++++-----------
include/hw/block/block.h | 6 ++--
include/hw/scsi/scsi.h | 7 ++--
tests/qemu-iotests/051.out | 4 +--
10 files changed, 128 insertions(+), 116 deletions(-)
--
2.0.3
next reply other threads:[~2014-08-11 8:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-11 8:45 Fam Zheng [this message]
2014-08-11 8:45 ` [Qemu-devel] [PATCH v3 1/2] block: Pass errp in blkconf_geometry Fam Zheng
2014-08-11 11:20 ` Andreas Färber
2014-08-11 14:24 ` Stefan Hajnoczi
2014-08-11 8:45 ` [Qemu-devel] [PATCH v3 2/2] scsi-bus: Convert DeviceClass init to realize Fam Zheng
2014-08-11 14:32 ` Stefan Hajnoczi
2014-08-12 2:04 ` Fam Zheng
2014-08-12 8:59 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407746718-16527-1-git-send-email-famz@redhat.com \
--to=famz@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).