From: Tom Musta <tommusta@gmail.com>
To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: Tom Musta <tommusta@gmail.com>, agraf@suse.de
Subject: [Qemu-devel] [PATCH 8/8] target-ppc: Bug Fix: srad
Date: Mon, 11 Aug 2014 14:23:29 -0500 [thread overview]
Message-ID: <1407785009-6538-9-git-send-email-tommusta@gmail.com> (raw)
In-Reply-To: <1407785009-6538-1-git-send-email-tommusta@gmail.com>
Fix the check for carry in the srad helper to properly construct
the mask -- a "1ULL" must be used (instead of "1") in order to
get the desired result.
Signed-off-by: Tom Musta <tommusta@gmail.com>
---
target-ppc/int_helper.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/target-ppc/int_helper.c b/target-ppc/int_helper.c
index e83a25d..e5b103b 100644
--- a/target-ppc/int_helper.c
+++ b/target-ppc/int_helper.c
@@ -248,7 +248,7 @@ target_ulong helper_srad(CPUPPCState *env, target_ulong value,
if (likely((uint64_t)shift != 0)) {
shift &= 0x3f;
ret = (int64_t)value >> shift;
- if (likely(ret >= 0 || (value & ((1 << shift) - 1)) == 0)) {
+ if (likely(ret >= 0 || (value & ((1ULL << shift) - 1)) == 0)) {
env->ca = 0;
} else {
env->ca = 1;
--
1.7.1
next prev parent reply other threads:[~2014-08-11 19:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-11 19:23 [Qemu-devel] [PATCH 0/8] target-ppc: Bug Fixes for 64 Bit FXU Instructions Tom Musta
2014-08-11 19:23 ` [Qemu-devel] [PATCH 1/8] target-ppc: Bug Fix: rlwinm Tom Musta
2014-08-15 18:34 ` Richard Henderson
2014-08-15 19:52 ` Richard Henderson
2014-08-11 19:23 ` [Qemu-devel] [PATCH 2/8] target-ppc: Bug Fix: rlwnm Tom Musta
2014-08-15 19:54 ` Richard Henderson
2014-08-11 19:23 ` [Qemu-devel] [PATCH 3/8] target-ppc: Bug Fix: rlwimi Tom Musta
2014-08-15 20:05 ` Richard Henderson
2014-08-18 19:51 ` Tom Musta
2014-08-11 19:23 ` [Qemu-devel] [PATCH 4/8] target-ppc: Bug Fix: mullw Tom Musta
2014-08-15 20:07 ` Richard Henderson
2014-08-11 19:23 ` [Qemu-devel] [PATCH 5/8] target-ppc: Bug Fix: mullwo Tom Musta
2014-08-15 20:11 ` Richard Henderson
2014-08-11 19:23 ` [Qemu-devel] [PATCH 6/8] target-ppc: Bug Fix: mulldo OV Detection Tom Musta
2014-08-15 20:16 ` Richard Henderson
2014-08-11 19:23 ` [Qemu-devel] [PATCH 7/8] target-ppc: Bug Fix: srawi Tom Musta
2014-08-11 19:23 ` Tom Musta [this message]
2014-08-15 20:17 ` [Qemu-devel] [PATCH 8/8] target-ppc: Bug Fix: srad Richard Henderson
2014-08-12 3:06 ` [Qemu-devel] [PATCH 0/8] target-ppc: Bug Fixes for 64 Bit FXU Instructions David Gibson
2014-08-12 11:40 ` Tom Musta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407785009-6538-9-git-send-email-tommusta@gmail.com \
--to=tommusta@gmail.com \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).