Re: [Qemu-devel] [PATCH v5 06/10] hw/vfio: create common module

[Alex Williamson <alex.williamson@redhat.com>]

On Sat, 2014-08-09 at 15:25 +0100, Eric Auger wrote:
> diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio-common.h
> new file mode 100644
> index 0000000..4684ee5
> --- /dev/null
> +++ b/include/hw/vfio/vfio-common.h
> @@ -0,0 +1,151 @@
> +/*
> + * common header for vfio based device assignment support
> + *
> + * Copyright Red Hat, Inc. 2012
> + *
> + * Authors:
> + *  Alex Williamson <alex.williamson@redhat.com>
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2.  See
> + * the COPYING file in the top-level directory.
> + *
> + * Based on qemu-kvm device-assignment:
> + *  Adapted for KVM by Qumranet.
> + *  Copyright (c) 2007, Neocleus, Alex Novik (alex@neocleus.com)
> + *  Copyright (c) 2007, Neocleus, Guy Zana (guy@neocleus.com)
> + *  Copyright (C) 2008, Qumranet, Amit Shah (amit.shah@qumranet.com)
> + *  Copyright (C) 2008, Red Hat, Amit Shah (amit.shah@redhat.com)
> + *  Copyright (C) 2008, IBM, Muli Ben-Yehuda (muli@il.ibm.com)
> + */
> +#ifndef HW_VFIO_VFIO_COMMON_H
> +#define HW_VFIO_VFIO_COMMON_H
> +
> +#include "qemu-common.h"
> +#include "exec/address-spaces.h"
> +#include "exec/memory.h"
> +#include "qemu/queue.h"
> +#include "qemu/notify.h"
> +
> +/*#define DEBUG_VFIO*/
> +#ifdef DEBUG_VFIO
> +#define DPRINTF(fmt, ...) \
> +    do { fprintf(stderr, "vfio: " fmt, ## __VA_ARGS__); } while (0)
> +#else
> +#define DPRINTF(fmt, ...) \
> +    do { } while (0)
> +#endif


DPRINTF also need to be renamed to avoid conflicting namespace issues.
Thanks,

Alex