qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Tom Musta <tommusta@gmail.com>
To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: Tom Musta <tommusta@gmail.com>,
	agraf@suse.de, david@gibson.dropbear.id.au
Subject: [Qemu-devel] [V2 PATCH 7/8] target-ppc: Bug Fix: srawi
Date: Tue, 12 Aug 2014 08:45:09 -0500	[thread overview]
Message-ID: <1407851110-8075-8-git-send-email-tommusta@gmail.com> (raw)
In-Reply-To: <1407851110-8075-1-git-send-email-tommusta@gmail.com>

For 64 bit implementations, the special case of a shift by zero
should result in the sign extension of the least significant 32 bits
of the source GPR (not a direct copy of the 64 bit source GPR).

Example:

R3 A6212433228F41DC
srawi 3,3,0
R3 expected : 00000000228F41DC
R3 actual   : A6212433228F41DC (without this patch)

Signed-off-by: Tom Musta <tommusta@gmail.com>
---
 target-ppc/translate.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/target-ppc/translate.c b/target-ppc/translate.c
index 4904665..61fa42d 100644
--- a/target-ppc/translate.c
+++ b/target-ppc/translate.c
@@ -1941,7 +1941,7 @@ static void gen_srawi(DisasContext *ctx)
     TCGv dst = cpu_gpr[rA(ctx->opcode)];
     TCGv src = cpu_gpr[rS(ctx->opcode)];
     if (sh == 0) {
-        tcg_gen_mov_tl(dst, src);
+        tcg_gen_ext32s_tl(dst, src);
         tcg_gen_movi_tl(cpu_ca, 0);
     } else {
         TCGv t0;
-- 
1.7.1

  parent reply	other threads:[~2014-08-12 13:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-12 13:45 [Qemu-devel] [V2 PATCH 0/8] target-ppc: Bug Fixes for 64 Bit FXU Instructions Tom Musta
2014-08-12 13:45 ` [Qemu-devel] [V2 PATCH 1/8] target-ppc: Bug Fix: rlwinm Tom Musta
2014-08-15 20:28   ` Richard Henderson
2014-08-12 13:45 ` [Qemu-devel] [V2 PATCH 2/8] target-ppc: Bug Fix: rlwnm Tom Musta
2014-08-15 20:33   ` Richard Henderson
2014-08-12 13:45 ` [Qemu-devel] [V2 PATCH 3/8] target-ppc: Bug Fix: rlwimi Tom Musta
2014-08-12 13:45 ` [Qemu-devel] [V2 PATCH 4/8] target-ppc: Bug Fix: mullw Tom Musta
2014-08-15 20:36   ` Richard Henderson
2014-08-12 13:45 ` [Qemu-devel] [V2 PATCH 5/8] target-ppc: Bug Fix: mullwo Tom Musta
2014-08-12 13:45 ` [Qemu-devel] [V2 PATCH 6/8] target-ppc: Bug Fix: mulldo OV Detection Tom Musta
2014-08-12 13:45 ` Tom Musta [this message]
2014-08-15 20:39   ` [Qemu-devel] [V2 PATCH 7/8] target-ppc: Bug Fix: srawi Richard Henderson
2014-08-12 13:45 ` [Qemu-devel] [V2 PATCH 8/8] target-ppc: Bug Fix: srad Tom Musta
2014-08-12 14:20 ` [Qemu-devel] [V2 PATCH 0/8] target-ppc: Bug Fixes for 64 Bit FXU Instructions Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1407851110-8075-8-git-send-email-tommusta@gmail.com \
    --to=tommusta@gmail.com \
    --cc=agraf@suse.de \
    --cc=david@gibson.dropbear.id.au \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).