From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42610) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XHCP6-0005bS-Us for qemu-devel@nongnu.org; Tue, 12 Aug 2014 09:46:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XHCOx-0002jJ-PY for qemu-devel@nongnu.org; Tue, 12 Aug 2014 09:46:20 -0400 From: Tom Musta Date: Tue, 12 Aug 2014 08:45:10 -0500 Message-Id: <1407851110-8075-9-git-send-email-tommusta@gmail.com> In-Reply-To: <1407851110-8075-1-git-send-email-tommusta@gmail.com> References: <1407851110-8075-1-git-send-email-tommusta@gmail.com> Subject: [Qemu-devel] [V2 PATCH 8/8] target-ppc: Bug Fix: srad List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org Cc: Tom Musta , agraf@suse.de, david@gibson.dropbear.id.au Fix the check for carry in the srad helper to properly construct the mask -- a "1ULL" must be used (instead of "1") in order to get the desired result. Example: R3 8000000000000000 R4 F3511AD4A2CD4C38 srad 3,3,4 Should *not* set XER[CA] but does without this patch. Signed-off-by: Tom Musta --- target-ppc/int_helper.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-ppc/int_helper.c b/target-ppc/int_helper.c index e83a25d..e5b103b 100644 --- a/target-ppc/int_helper.c +++ b/target-ppc/int_helper.c @@ -248,7 +248,7 @@ target_ulong helper_srad(CPUPPCState *env, target_ulong value, if (likely((uint64_t)shift != 0)) { shift &= 0x3f; ret = (int64_t)value >> shift; - if (likely(ret >= 0 || (value & ((1 << shift) - 1)) == 0)) { + if (likely(ret >= 0 || (value & ((1ULL << shift) - 1)) == 0)) { env->ca = 0; } else { env->ca = 1; -- 1.7.1