* [Qemu-devel] [PATCH] hw/intc/arm_gic: honor target mask in gic_update()
@ 2014-08-13 16:31 Sergey Fedorov
2014-08-15 11:57 ` Christoffer Dall
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Sergey Fedorov @ 2014-08-13 16:31 UTC (permalink / raw)
To: qemu-devel
Cc: Peter Maydell, Marcel Apfelbaum, Markus Armbruster,
Sergey Fedorov, Andreas Färber, Christoffer Dall
Take IRQ target mask into account when determining the highest priority
pending interrupt.
Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
---
hw/intc/arm_gic.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/intc/arm_gic.c b/hw/intc/arm_gic.c
index 1532ef9..a5ad7b9 100644
--- a/hw/intc/arm_gic.c
+++ b/hw/intc/arm_gic.c
@@ -66,7 +66,8 @@ void gic_update(GICState *s)
best_prio = 0x100;
best_irq = 1023;
for (irq = 0; irq < s->num_irq; irq++) {
- if (GIC_TEST_ENABLED(irq, cm) && gic_test_pending(s, irq, cm)) {
+ if (GIC_TEST_ENABLED(irq, cm) && gic_test_pending(s, irq, cm) &&
+ (irq < GIC_INTERNAL || GIC_TARGET(irq) & cm)) {
if (GIC_GET_PRIORITY(irq, cpu) < best_prio) {
best_prio = GIC_GET_PRIORITY(irq, cpu);
best_irq = irq;
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] hw/intc/arm_gic: honor target mask in gic_update()
2014-08-13 16:31 [Qemu-devel] [PATCH] hw/intc/arm_gic: honor target mask in gic_update() Sergey Fedorov
@ 2014-08-15 11:57 ` Christoffer Dall
2014-08-25 9:41 ` Sergey Fedorov
2014-08-29 13:25 ` Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Christoffer Dall @ 2014-08-15 11:57 UTC (permalink / raw)
To: Sergey Fedorov
Cc: Peter Maydell, Marcel Apfelbaum, qemu-devel, Andreas Färber,
Markus Armbruster
On Wed, Aug 13, 2014 at 08:31:11PM +0400, Sergey Fedorov wrote:
> Take IRQ target mask into account when determining the highest priority
> pending interrupt.
>
> Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
> ---
> hw/intc/arm_gic.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/intc/arm_gic.c b/hw/intc/arm_gic.c
> index 1532ef9..a5ad7b9 100644
> --- a/hw/intc/arm_gic.c
> +++ b/hw/intc/arm_gic.c
> @@ -66,7 +66,8 @@ void gic_update(GICState *s)
> best_prio = 0x100;
> best_irq = 1023;
> for (irq = 0; irq < s->num_irq; irq++) {
> - if (GIC_TEST_ENABLED(irq, cm) && gic_test_pending(s, irq, cm)) {
> + if (GIC_TEST_ENABLED(irq, cm) && gic_test_pending(s, irq, cm) &&
> + (irq < GIC_INTERNAL || GIC_TARGET(irq) & cm)) {
> if (GIC_GET_PRIORITY(irq, cpu) < best_prio) {
> best_prio = GIC_GET_PRIORITY(irq, cpu);
> best_irq = irq;
> --
> 1.9.1
>
Acked-by: Christoffer Dall <christoffer.dall@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] hw/intc/arm_gic: honor target mask in gic_update()
2014-08-13 16:31 [Qemu-devel] [PATCH] hw/intc/arm_gic: honor target mask in gic_update() Sergey Fedorov
2014-08-15 11:57 ` Christoffer Dall
@ 2014-08-25 9:41 ` Sergey Fedorov
2014-08-29 13:25 ` Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Sergey Fedorov @ 2014-08-25 9:41 UTC (permalink / raw)
To: qemu-devel
Cc: Peter Maydell, Marcel Apfelbaum, Markus Armbruster,
Christoffer Dall, Andreas Färber
Ping.
On 13.08.2014 20:31, Sergey Fedorov wrote:
> Take IRQ target mask into account when determining the highest priority
> pending interrupt.
>
> Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
> ---
> hw/intc/arm_gic.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/intc/arm_gic.c b/hw/intc/arm_gic.c
> index 1532ef9..a5ad7b9 100644
> --- a/hw/intc/arm_gic.c
> +++ b/hw/intc/arm_gic.c
> @@ -66,7 +66,8 @@ void gic_update(GICState *s)
> best_prio = 0x100;
> best_irq = 1023;
> for (irq = 0; irq < s->num_irq; irq++) {
> - if (GIC_TEST_ENABLED(irq, cm) && gic_test_pending(s, irq, cm)) {
> + if (GIC_TEST_ENABLED(irq, cm) && gic_test_pending(s, irq, cm) &&
> + (irq < GIC_INTERNAL || GIC_TARGET(irq) & cm)) {
> if (GIC_GET_PRIORITY(irq, cpu) < best_prio) {
> best_prio = GIC_GET_PRIORITY(irq, cpu);
> best_irq = irq;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] hw/intc/arm_gic: honor target mask in gic_update()
2014-08-13 16:31 [Qemu-devel] [PATCH] hw/intc/arm_gic: honor target mask in gic_update() Sergey Fedorov
2014-08-15 11:57 ` Christoffer Dall
2014-08-25 9:41 ` Sergey Fedorov
@ 2014-08-29 13:25 ` Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2014-08-29 13:25 UTC (permalink / raw)
To: Sergey Fedorov
Cc: Marcel Apfelbaum, Andreas Färber, QEMU Developers,
Christoffer Dall, Markus Armbruster
On 13 August 2014 17:31, Sergey Fedorov <serge.fdrv@gmail.com> wrote:
> Take IRQ target mask into account when determining the highest priority
> pending interrupt.
>
> Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
Thanks, applied to target-arm.next.
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-08-29 13:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-13 16:31 [Qemu-devel] [PATCH] hw/intc/arm_gic: honor target mask in gic_update() Sergey Fedorov
2014-08-15 11:57 ` Christoffer Dall
2014-08-25 9:41 ` Sergey Fedorov
2014-08-29 13:25 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).