From: Tom Musta <tommusta@gmail.com>
To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: Tom Musta <tommusta@gmail.com>, riku.voipio@linaro.org, agraf@suse.de
Subject: [Qemu-devel] [V3 PATCH 11/13] linux-user: clock_nanosleep errno Handling on PPC
Date: Wed, 13 Aug 2014 14:04:46 -0500 [thread overview]
Message-ID: <1407956688-16006-12-git-send-email-tommusta@gmail.com> (raw)
In-Reply-To: <1407956688-16006-1-git-send-email-tommusta@gmail.com>
The clock_nanosleep syscall is unusual in that it returns positive
numbers in error handling situations, versus returning -1 and setting
errno, or returning a negative errno value. On POWER, the kernel will
set the SO bit of CR0 to indicate failure in a syscall. QEMU has
generic handling to do this for syscalls with standard return values.
Add special case code for clock_nanosleep to handle CR0 properly.
Signed-off-by: Tom Musta <tommusta@gmail.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
---
V2: Eliminated redundant "#if defined" condition per Peter Maydell's
review.
linux-user/syscall.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index a20c2f7..fc828ae 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -8999,6 +8999,14 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
ret = get_errno(clock_nanosleep(arg1, arg2, &ts, arg4 ? &ts : NULL));
if (arg4)
host_to_target_timespec(arg4, &ts);
+
+#if defined(TARGET_PPC)
+ /* clock_nanosleep is odd in that it returns positive errno values.
+ * On PPC, CR0 bit 3 should be set in such a situation. */
+ if (ret) {
+ ((CPUPPCState *)cpu_env)->crf[0] |= 1;
+ }
+#endif
break;
}
#endif
--
1.7.1
next prev parent reply other threads:[~2014-08-13 19:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 19:04 [Qemu-devel] [V3 PATCH 00/13] target-ppc: Linux-User Mode Bug Fixes for Power Tom Musta
2014-08-13 19:04 ` [Qemu-devel] [V3 PATCH 01/13] linux-user: PPC64 semid_ds Doesnt Include _unused1 and _unused2 Tom Musta
2014-08-13 19:04 ` [Qemu-devel] [V3 PATCH 02/13] linux-user: Dereference Pointer Argument to ipc/semctl Sys Call Tom Musta
2014-08-13 19:04 ` [Qemu-devel] [V3 PATCH 03/13] linux-user: Properly Handle semun Structure In Cross-Endian Situations Tom Musta
2014-08-13 19:04 ` [Qemu-devel] [V3 PATCH 04/13] linux-user: Make ipc syscall's third argument an abi_long Tom Musta
2014-08-13 19:04 ` [Qemu-devel] [V3 PATCH 05/13] linux-user: Conditionally Pass Attribute Pointer to mq_open() Tom Musta
2014-08-13 19:04 ` [Qemu-devel] [V3 PATCH 06/13] linux-user: Detect Negative Message Sizes in msgsnd System Call Tom Musta
2014-08-13 19:04 ` [Qemu-devel] [V3 PATCH 07/13] linux-user: Handle NULL sched_param argument to sched_* Tom Musta
2014-08-13 19:04 ` [Qemu-devel] [V3 PATCH 08/13] linux-user: Detect fault in sched_rr_get_interval Tom Musta
2014-08-13 19:04 ` [Qemu-devel] [V3 PATCH 09/13] linux-user: Move get_ppc64_abi Tom Musta
2014-08-13 19:04 ` [Qemu-devel] [V3 PATCH 10/13] linux-user: Minimum Sig Handler Stack Size for PPC64 ELF V2 Tom Musta
2014-08-13 19:04 ` Tom Musta [this message]
2014-08-13 19:04 ` [Qemu-devel] [V3 PATCH 12/13] linux-user: Support target-to-host translation of mlockall argument Tom Musta
2014-08-13 19:04 ` [Qemu-devel] [V3 PATCH 13/13] linux-user: writev Partial Writes Tom Musta
2014-08-14 13:30 ` [Qemu-devel] [V3 PATCH 00/13] target-ppc: Linux-User Mode Bug Fixes for Power Riku Voipio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407956688-16006-12-git-send-email-tommusta@gmail.com \
--to=tommusta@gmail.com \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=riku.voipio@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).