From: Tom Musta <tommusta@gmail.com>
To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: Tom Musta <tommusta@gmail.com>, riku.voipio@linaro.org, agraf@suse.de
Subject: [Qemu-devel] [V3 PATCH 06/13] linux-user: Detect Negative Message Sizes in msgsnd System Call
Date: Wed, 13 Aug 2014 14:04:41 -0500 [thread overview]
Message-ID: <1407956688-16006-7-git-send-email-tommusta@gmail.com> (raw)
In-Reply-To: <1407956688-16006-1-git-send-email-tommusta@gmail.com>
The msgsnd system call takes an argument that describes the message
size (msgsz) and is of type size_t. The system call should set
errno to EINVAL in the event that a negative message size is passed.
Signed-off-by: Tom Musta <tommusta@gmail.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
---
linux-user/syscall.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 04f4820..79fb3cb 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -2874,12 +2874,16 @@ struct target_msgbuf {
};
static inline abi_long do_msgsnd(int msqid, abi_long msgp,
- unsigned int msgsz, int msgflg)
+ ssize_t msgsz, int msgflg)
{
struct target_msgbuf *target_mb;
struct msgbuf *host_mb;
abi_long ret = 0;
+ if (msgsz < 0) {
+ return -TARGET_EINVAL;
+ }
+
if (!lock_user_struct(VERIFY_READ, target_mb, msgp, 0))
return -TARGET_EFAULT;
host_mb = malloc(msgsz+sizeof(long));
--
1.7.1
next prev parent reply other threads:[~2014-08-13 19:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 19:04 [Qemu-devel] [V3 PATCH 00/13] target-ppc: Linux-User Mode Bug Fixes for Power Tom Musta
2014-08-13 19:04 ` [Qemu-devel] [V3 PATCH 01/13] linux-user: PPC64 semid_ds Doesnt Include _unused1 and _unused2 Tom Musta
2014-08-13 19:04 ` [Qemu-devel] [V3 PATCH 02/13] linux-user: Dereference Pointer Argument to ipc/semctl Sys Call Tom Musta
2014-08-13 19:04 ` [Qemu-devel] [V3 PATCH 03/13] linux-user: Properly Handle semun Structure In Cross-Endian Situations Tom Musta
2014-08-13 19:04 ` [Qemu-devel] [V3 PATCH 04/13] linux-user: Make ipc syscall's third argument an abi_long Tom Musta
2014-08-13 19:04 ` [Qemu-devel] [V3 PATCH 05/13] linux-user: Conditionally Pass Attribute Pointer to mq_open() Tom Musta
2014-08-13 19:04 ` Tom Musta [this message]
2014-08-13 19:04 ` [Qemu-devel] [V3 PATCH 07/13] linux-user: Handle NULL sched_param argument to sched_* Tom Musta
2014-08-13 19:04 ` [Qemu-devel] [V3 PATCH 08/13] linux-user: Detect fault in sched_rr_get_interval Tom Musta
2014-08-13 19:04 ` [Qemu-devel] [V3 PATCH 09/13] linux-user: Move get_ppc64_abi Tom Musta
2014-08-13 19:04 ` [Qemu-devel] [V3 PATCH 10/13] linux-user: Minimum Sig Handler Stack Size for PPC64 ELF V2 Tom Musta
2014-08-13 19:04 ` [Qemu-devel] [V3 PATCH 11/13] linux-user: clock_nanosleep errno Handling on PPC Tom Musta
2014-08-13 19:04 ` [Qemu-devel] [V3 PATCH 12/13] linux-user: Support target-to-host translation of mlockall argument Tom Musta
2014-08-13 19:04 ` [Qemu-devel] [V3 PATCH 13/13] linux-user: writev Partial Writes Tom Musta
2014-08-14 13:30 ` [Qemu-devel] [V3 PATCH 00/13] target-ppc: Linux-User Mode Bug Fixes for Power Riku Voipio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407956688-16006-7-git-send-email-tommusta@gmail.com \
--to=tommusta@gmail.com \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=riku.voipio@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).