From: zhanghailiang <zhang.zhanghailiang@huawei.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, stefanha@redhat.com, mst@redhat.com,
luonengjun@huawei.com, peter.huangpeng@huawei.com,
aliguori@amazon.com, akong@redhat.com,
zhanghailiang <zhang.zhanghailiang@huawei.com>
Subject: [Qemu-devel] [PATCH 2/3] net: Flush queues when runstate changes back to running
Date: Thu, 14 Aug 2014 14:13:57 +0800 [thread overview]
Message-ID: <1407996838-10212-3-git-send-email-zhang.zhanghailiang@huawei.com> (raw)
In-Reply-To: <1407996838-10212-1-git-send-email-zhang.zhanghailiang@huawei.com>
When the runstate changes back to running, we definitely need to flush
queues to get packets flowing again.
Here we implement this in the net layer:
(1) add a member 'VMChangeStateEntry *vmstate' to struct NICState,
Which will listen for VM runstate changes.
(2) Register a handler function for VMstate change.
When vm changes back to running, we flush all queues in the callback function.
Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
---
include/net/net.h | 1 +
net/net.c | 26 ++++++++++++++++++++++++++
2 files changed, 27 insertions(+)
diff --git a/include/net/net.h b/include/net/net.h
index 312f728..a294277 100644
--- a/include/net/net.h
+++ b/include/net/net.h
@@ -97,6 +97,7 @@ typedef struct NICState {
NICConf *conf;
void *opaque;
bool peer_deleted;
+ VMChangeStateEntry *vmstate;
} NICState;
NetClientState *qemu_find_netdev(const char *id);
diff --git a/net/net.c b/net/net.c
index 5bb2821..506e58f 100644
--- a/net/net.c
+++ b/net/net.c
@@ -242,6 +242,29 @@ NetClientState *qemu_new_net_client(NetClientInfo *info,
return nc;
}
+static void nic_vmstate_change_handler(void *opaque,
+ int running,
+ RunState state)
+{
+ NICState *nic = opaque;
+ NetClientState *nc;
+ int i, queues;
+
+ if (!running) {
+ return;
+ }
+
+ queues = MAX(1, nic->conf->peers.queues);
+ for (i = 0; i < queues; i++) {
+ nc = &nic->ncs[i];
+ if (nc->receive_disabled
+ || (nc->info->can_receive && !nc->info->can_receive(nc))) {
+ continue;
+ }
+ qemu_flush_queued_packets(nc);
+ }
+}
+
NICState *qemu_new_nic(NetClientInfo *info,
NICConf *conf,
const char *model,
@@ -259,6 +282,8 @@ NICState *qemu_new_nic(NetClientInfo *info,
nic->ncs = (void *)nic + info->size;
nic->conf = conf;
nic->opaque = opaque;
+ nic->vmstate = qemu_add_vm_change_state_handler(nic_vmstate_change_handler,
+ nic);
for (i = 0; i < queues; i++) {
qemu_net_client_setup(&nic->ncs[i], info, peers[i], model, name,
@@ -379,6 +404,7 @@ void qemu_del_nic(NICState *nic)
qemu_free_net_client(nc);
}
+ qemu_del_vm_change_state_handler(nic->vmstate);
g_free(nic);
}
--
1.7.12.4
next prev parent reply other threads:[~2014-08-14 6:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 6:13 [Qemu-devel] [PATCH 0/3] forbid dealing with net packets when VM is not running zhanghailiang
2014-08-14 6:13 ` [Qemu-devel] [PATCH 1/3] net: Forbid dealing with " zhanghailiang
2014-08-14 6:13 ` zhanghailiang [this message]
2014-08-14 7:12 ` [Qemu-devel] [PATCH 2/3] net: Flush queues when runstate changes back to running Gonglei (Arei)
2014-08-14 8:24 ` zhanghailiang
2014-08-14 10:05 ` Michael S. Tsirkin
2014-08-18 0:45 ` zhanghailiang
2014-08-14 10:09 ` Michael S. Tsirkin
2014-08-18 0:46 ` zhanghailiang
2014-08-14 6:13 ` [Qemu-devel] [PATCH 3/3] virtio-net: Remove checking vm state in virtio_net_can_receive zhanghailiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407996838-10212-3-git-send-email-zhang.zhanghailiang@huawei.com \
--to=zhang.zhanghailiang@huawei.com \
--cc=akong@redhat.com \
--cc=aliguori@amazon.com \
--cc=luonengjun@huawei.com \
--cc=mst@redhat.com \
--cc=peter.huangpeng@huawei.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).