From: zhanghailiang <zhang.zhanghailiang@huawei.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, lkurusa@redhat.com,
zhanghailiang <zhang.zhanghailiang@huawei.com>,
mst@redhat.com, qemu-trivial@nongnu.org, jan.kiszka@siemens.com,
riku.voipio@iki.fi, mjt@tls.msk.ru, peter.huangpeng@huawei.com,
lcapitulino@redhat.com, stefanha@redhat.com,
luonengjun@huawei.com, pbonzini@redhat.com,
alex.bennee@linaro.org, rth@twiddle.net
Subject: [Qemu-devel] [PATCH v6 05/10] util/path: Use the GLib memory allocation routines
Date: Thu, 14 Aug 2014 15:29:16 +0800 [thread overview]
Message-ID: <1408001361-13580-6-git-send-email-zhang.zhanghailiang@huawei.com> (raw)
In-Reply-To: <1408001361-13580-1-git-send-email-zhang.zhanghailiang@huawei.com>
In this file, we don't check the return value of malloc/strdup/realloc which may fail.
Instead of using these routines, we use the GLib memory APIs g_malloc/g_strdup/g_realloc.
They will exit on allocation failure, so there is no need to test for failure,
which would be fine for setup.
Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
---
util/path.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/util/path.c b/util/path.c
index 5c59d9f..e152f2a 100644
--- a/util/path.c
+++ b/util/path.c
@@ -45,8 +45,8 @@ static struct pathelem *new_entry(const char *root,
struct pathelem *parent,
const char *name)
{
- struct pathelem *new = malloc(sizeof(*new));
- new->name = strdup(name);
+ struct pathelem *new = g_malloc(sizeof(*new));
+ new->name = g_strdup(name);
new->pathname = g_strdup_printf("%s/%s", root, name);
new->num_entries = 0;
return new;
@@ -88,7 +88,7 @@ static struct pathelem *add_entry(struct pathelem *root, const char *name,
root->num_entries++;
- root = realloc(root, sizeof(*root)
+ root = g_realloc(root, sizeof(*root)
+ sizeof(root->entries[0])*root->num_entries);
e = &root->entries[root->num_entries-1];
--
1.7.12.4
next prev parent reply other threads:[~2014-08-14 7:32 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 7:29 [Qemu-devel] [PATCH v6 00/10] fix three bugs about use-after-free and several api abuse zhanghailiang
2014-08-14 7:29 ` [Qemu-devel] [PATCH v6 01/10] l2cap: fix access freed memory zhanghailiang
2014-08-14 10:19 ` Michael S. Tsirkin
2014-08-15 14:58 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-08-14 7:29 ` [Qemu-devel] [PATCH v6 02/10] monitor: " zhanghailiang
2014-08-14 10:30 ` Michael S. Tsirkin
2014-08-15 18:25 ` Luiz Capitulino
2014-08-17 9:45 ` Michael S. Tsirkin
2014-08-17 10:55 ` Michael S. Tsirkin
2014-08-14 7:29 ` [Qemu-devel] [PATCH v6 03/10] virtio-blk: fix reference a pointer which might be freed zhanghailiang
2014-08-14 10:37 ` Michael S. Tsirkin
2014-08-14 10:39 ` Michael Tokarev
2014-08-14 11:16 ` Michael S. Tsirkin
2014-08-18 11:49 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-08-18 20:17 ` Michael S. Tsirkin
2014-08-19 7:19 ` Michael Tokarev
2014-08-14 7:29 ` [Qemu-devel] [PATCH v6 04/10] ivshmem: check the value returned by fstat() zhanghailiang
2014-08-14 10:12 ` Michael S. Tsirkin
2014-08-15 14:59 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-08-14 7:29 ` zhanghailiang [this message]
2014-08-14 10:15 ` [Qemu-devel] [PATCH v6 05/10] util/path: Use the GLib memory allocation routines Michael S. Tsirkin
2014-08-18 5:59 ` zhanghailiang
2014-08-14 7:29 ` [Qemu-devel] [PATCH v6 06/10] slirp/misc: Use g_malloc() instead of malloc() zhanghailiang
2014-08-14 10:31 ` Michael S. Tsirkin
2014-08-18 0:29 ` zhanghailiang
2014-08-18 5:56 ` zhanghailiang
2014-08-14 7:29 ` [Qemu-devel] [PATCH v6 07/10] linux-user: check return value " zhanghailiang
2014-08-14 13:31 ` Riku Voipio
2014-08-14 18:04 ` Michael Tokarev
2014-08-18 20:17 ` Michael S. Tsirkin
2014-08-14 7:29 ` [Qemu-devel] [PATCH v6 08/10] tests/bios-tables-test: check the value returned by fopen() zhanghailiang
2014-08-14 10:32 ` Michael S. Tsirkin
2014-08-18 0:32 ` zhanghailiang
2014-08-14 7:29 ` [Qemu-devel] [PATCH v6 09/10] tcg: check return value of fopen() zhanghailiang
2014-08-14 10:33 ` Michael S. Tsirkin
2014-08-15 15:03 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-08-15 16:53 ` Richard Henderson
2014-08-18 6:21 ` zhanghailiang
2014-08-14 7:29 ` [Qemu-devel] [PATCH v6 10/10] block/vvfat: fix setbuf stream parameter may be NULL zhanghailiang
2014-08-14 10:36 ` Michael S. Tsirkin
2014-08-18 0:55 ` zhanghailiang
2014-08-14 10:17 ` [Qemu-devel] [PATCH v6 00/10] fix three bugs about use-after-free and several api abuse Michael S. Tsirkin
2014-08-14 10:38 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408001361-13580-6-git-send-email-zhang.zhanghailiang@huawei.com \
--to=zhang.zhanghailiang@huawei.com \
--cc=alex.bennee@linaro.org \
--cc=jan.kiszka@siemens.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=lkurusa@redhat.com \
--cc=luonengjun@huawei.com \
--cc=mjt@tls.msk.ru \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).