From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47699) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJHjb-0004f6-CS for qemu-devel@nongnu.org; Mon, 18 Aug 2014 03:52:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XJHjX-0008LW-1I for qemu-devel@nongnu.org; Mon, 18 Aug 2014 03:52:07 -0400 From: zhanghailiang Date: Mon, 18 Aug 2014 15:51:50 +0800 Message-ID: <1408348310-6628-1-git-send-email-zhang.zhanghailiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH v7] slirp/misc: Use g_malloc() instead of malloc() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, jan.kiszka@siemens.com, luonengjun@huawei.com, peter.huangpeng@huawei.com, zhanghailiang Here we don't check the return value of malloc() which may fail. Use the g_malloc() instead, which will abort the program when there is not enough memory. Signed-off-by: zhanghailiang Reviewed-by: Alex Bennée --- slirp/misc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/slirp/misc.c b/slirp/misc.c index b8eb74c..f7fe497 100644 --- a/slirp/misc.c +++ b/slirp/misc.c @@ -54,7 +54,7 @@ int add_exec(struct ex_list **ex_ptr, int do_pty, char *exec, } tmp_ptr = *ex_ptr; - *ex_ptr = (struct ex_list *)malloc(sizeof(struct ex_list)); + *ex_ptr = (struct ex_list *)g_malloc(sizeof(struct ex_list)); (*ex_ptr)->ex_fport = port; (*ex_ptr)->ex_addr = addr; (*ex_ptr)->ex_pty = do_pty; @@ -235,7 +235,7 @@ strdup(str) { char *bptr; - bptr = (char *)malloc(strlen(str)+1); + bptr = (char *)g_malloc(strlen(str)+1); strcpy(bptr, str); return bptr; -- 1.7.12.4