qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: zhanghailiang <zhang.zhanghailiang@huawei.com>
To: qemu-devel@nongnu.org
Cc: zhanghailiang <zhang.zhanghailiang@huawei.com>,
	marcel.a@redhat.com, qemu-trivial@nongnu.org,
	Li Liu <john.liuli@huawei.com>,
	mst@redhat.com, luonengjun@huawei.com,
	peter.huangpeng@huawei.com
Subject: [Qemu-devel] [PATCH v7] tests/bios-tables-test: check the value returned by fopen()
Date: Mon, 18 Aug 2014 15:54:33 +0800	[thread overview]
Message-ID: <1408348473-10104-1-git-send-email-zhang.zhanghailiang@huawei.com> (raw)

The function fopen() may fail, so check its return value.

Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
Signed-off-by: Li Liu <john.liuli@huawei.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
---
 tests/bios-tables-test.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c
index 045eb27..feb3b58 100644
--- a/tests/bios-tables-test.c
+++ b/tests/bios-tables-test.c
@@ -790,6 +790,11 @@ int main(int argc, char *argv[])
     const char *arch = qtest_get_arch();
     FILE *f = fopen(disk, "w");
     int ret;
+
+    if (!f) {
+        fprintf(stderr, "Couldn't open \"%s\": %s", disk, strerror(errno));
+        return -1;
+    }
     fwrite(boot_sector, 1, sizeof boot_sector, f);
     fclose(f);
 
-- 
1.7.12.4

             reply	other threads:[~2014-08-18  7:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-18  7:54 zhanghailiang [this message]
2014-08-18  8:10 ` [Qemu-devel] [PATCH v7] tests/bios-tables-test: check the value returned by fopen() Peter Maydell
2014-08-18  9:13 ` Marcel Apfelbaum
2014-08-18 11:37   ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-08-18 12:26     ` Marcel Apfelbaum
2014-08-18 13:51     ` Michael S. Tsirkin
2014-08-18 11:38 ` Michael Tokarev
2014-08-18 13:44   ` Michael S. Tsirkin
2014-08-18 14:24     ` Michael Tokarev
2014-08-18 19:36       ` Michael S. Tsirkin
2014-08-18 21:01         ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1408348473-10104-1-git-send-email-zhang.zhanghailiang@huawei.com \
    --to=zhang.zhanghailiang@huawei.com \
    --cc=john.liuli@huawei.com \
    --cc=luonengjun@huawei.com \
    --cc=marcel.a@redhat.com \
    --cc=mst@redhat.com \
    --cc=peter.huangpeng@huawei.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).