From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48680) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJHpu-0007Q9-Il for qemu-devel@nongnu.org; Mon, 18 Aug 2014 03:58:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XJHpp-0001c0-OZ for qemu-devel@nongnu.org; Mon, 18 Aug 2014 03:58:38 -0400 From: zhanghailiang Date: Mon, 18 Aug 2014 15:58:08 +0800 Message-ID: <1408348688-10260-1-git-send-email-zhang.zhanghailiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH v7] tcg: dump op count into qemu log List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: zhanghailiang , qemu-trivial@nongnu.org, mjt@tls.msk.ru, luonengjun@huawei.com, peter.huangpeng@huawei.com, Li Liu , rth@twiddle.net fopen() may fail and it does not check its return vaule here, it is better to dump op count to the normal log file. Signed-off-by: Li Liu Signed-off-by: zhanghailiang --- tcg/tcg.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index c068990..7a84b87 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -2404,12 +2404,10 @@ static int64_t tcg_table_op_count[NB_OPS]; static void dump_op_count(void) { int i; - FILE *f; - f = fopen("/tmp/op.log", "w"); + for(i = INDEX_op_end; i < NB_OPS; i++) { - fprintf(f, "%s %" PRId64 "\n", tcg_op_defs[i].name, tcg_table_op_count[i]); + qemu_log("%s %" PRId64 "\n", tcg_op_defs[i].name, tcg_table_op_count[i]); } - fclose(f); } #endif -- 1.7.12.4