From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44578) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJOX0-0003vR-DU for qemu-devel@nongnu.org; Mon, 18 Aug 2014 11:07:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XJOWu-0001VW-8c for qemu-devel@nongnu.org; Mon, 18 Aug 2014 11:07:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25274) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJOWu-0001VS-0H for qemu-devel@nongnu.org; Mon, 18 Aug 2014 11:07:28 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7IF7QG3004316 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 18 Aug 2014 11:07:27 -0400 From: Stefan Hajnoczi Date: Mon, 18 Aug 2014 16:07:13 +0100 Message-Id: <1408374433-5360-3-git-send-email-stefanha@redhat.com> In-Reply-To: <1408374433-5360-1-git-send-email-stefanha@redhat.com> References: <1408374433-5360-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH 2/2] virtio-blk: allow drive_del with dataplane List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Paolo Bonzini , Fam Zheng , Stefan Hajnoczi Now that drive_del acquires the AioContext we can safely allow deleting the drive. As with non-dataplane mode, all I/Os submitted by the guest after drive_del will return EIO. This patch makes hot unplug work with virtio-blk dataplane. Previously drive_del reported an error because the device was busy. Signed-off-by: Stefan Hajnoczi --- hw/block/dataplane/virtio-blk.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c index d6ba65c..907d5c7 100644 --- a/hw/block/dataplane/virtio-blk.c +++ b/hw/block/dataplane/virtio-blk.c @@ -192,6 +192,7 @@ void virtio_blk_data_plane_create(VirtIODevice *vdev, VirtIOBlkConf *blk, error_setg(&s->blocker, "block device is in use by data plane"); bdrv_op_block_all(blk->conf.bs, s->blocker); + bdrv_op_unblock(blk->conf.bs, BLOCK_OP_TYPE_DRIVE_DEL, s->blocker); *dataplane = s; } -- 1.9.3