From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35853) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJXCD-00088S-6I for qemu-devel@nongnu.org; Mon, 18 Aug 2014 20:22:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XJXC3-000474-OK for qemu-devel@nongnu.org; Mon, 18 Aug 2014 20:22:41 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:53622) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJXC3-00046e-Ii for qemu-devel@nongnu.org; Mon, 18 Aug 2014 20:22:31 -0400 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 18 Aug 2014 20:22:31 -0400 From: Michael Roth Date: Mon, 18 Aug 2014 19:21:54 -0500 Message-Id: <1408407718-10835-9-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1408407718-10835-1-git-send-email-mdroth@linux.vnet.ibm.com> References: <1408407718-10835-1-git-send-email-mdroth@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 08/12] pci: allow 0 address for PCI IO regions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aik@ozlabs.ru, agraf@suse.de, ncmike@ncultra.org, qemu-ppc@nongnu.org, tyreld@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com Some kernels program a 0 address for io regions. PCI 3.0 spec section 6.2.5.1 doesn't seem to disallow this. Signed-off-by: Michael Roth --- hw/pci/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 351d320..9578749 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -1035,7 +1035,7 @@ static pcibus_t pci_bar_address(PCIDevice *d, /* Check if 32 bit BAR wraps around explicitly. * TODO: make priorities correct and remove this work around. */ - if (last_addr <= new_addr || new_addr == 0 || last_addr >= UINT32_MAX) { + if (last_addr <= new_addr || last_addr >= UINT32_MAX) { return PCI_BAR_UNMAPPED; } return new_addr; -- 1.9.1