From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, jcody@redhat.com, stefanha@redhat.com,
mreitz@redhat.com
Subject: [Qemu-devel] [PATCH v3 3/4] qemu-io-cmds: g_renew() can't fail, bury dead error handling
Date: Tue, 19 Aug 2014 10:31:10 +0200 [thread overview]
Message-ID: <1408437071-25162-4-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1408437071-25162-1-git-send-email-armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Jeff Cody <jcody@redhat.com>
---
qemu-io-cmds.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c
index afd8867..b224ede 100644
--- a/qemu-io-cmds.c
+++ b/qemu-io-cmds.c
@@ -115,22 +115,13 @@ static char **breakline(char *input, int *count)
int c = 0;
char *p;
char **rval = g_new0(char *, 1);
- char **tmp;
while (rval && (p = qemu_strsep(&input, " ")) != NULL) {
if (!*p) {
continue;
}
c++;
- tmp = g_renew(char *, rval, (c + 1));
- if (!tmp) {
- g_free(rval);
- rval = NULL;
- c = 0;
- break;
- } else {
- rval = tmp;
- }
+ rval = g_renew(char *, rval, (c + 1));
rval[c - 1] = p;
rval[c] = NULL;
}
--
1.9.3
next prev parent reply other threads:[~2014-08-19 8:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 8:31 [Qemu-devel] [PATCH v3 0/4] block: Use g_new() & friends more Markus Armbruster
2014-08-19 8:31 ` [Qemu-devel] [PATCH v3 1/4] block: Use g_new() & friends where that makes obvious sense Markus Armbruster
2014-08-19 8:31 ` [Qemu-devel] [PATCH v3 2/4] block: Use g_new() & friends to avoid multiplying sizes Markus Armbruster
2014-08-19 8:31 ` Markus Armbruster [this message]
2014-08-19 8:31 ` [Qemu-devel] [PATCH v3 4/4] block: Drop some superfluous casts from void * Markus Armbruster
2014-08-19 11:10 ` [Qemu-devel] [PATCH v3 0/4] block: Use g_new() & friends more Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408437071-25162-4-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).