* [Qemu-devel] [PATCH v2] pcihp: fix possible array out of bounds
@ 2014-08-20 5:52 arei.gonglei
2014-08-20 6:05 ` Marcel Apfelbaum
2014-08-20 19:46 ` Michael S. Tsirkin
0 siblings, 2 replies; 3+ messages in thread
From: arei.gonglei @ 2014-08-20 5:52 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.crosthwaite, marcel.a, weidong.huang, Gonglei, mst
From: Gonglei <arei.gonglei@huawei.com>
Prevent out-of-bounds array access on
acpi_pcihp_pci_status.
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
---
v2:
- change commit message.
- add 'Reviewed-by'
---
hw/acpi/pcihp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c
index fae663a..34dedf1 100644
--- a/hw/acpi/pcihp.c
+++ b/hw/acpi/pcihp.c
@@ -231,7 +231,7 @@ static uint64_t pci_read(void *opaque, hwaddr addr, unsigned int size)
uint32_t val = 0;
int bsel = s->hotplug_select;
- if (bsel < 0 || bsel > ACPI_PCIHP_MAX_HOTPLUG_BUS) {
+ if (bsel < 0 || bsel >= ACPI_PCIHP_MAX_HOTPLUG_BUS) {
return 0;
}
--
1.7.12.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH v2] pcihp: fix possible array out of bounds
2014-08-20 5:52 [Qemu-devel] [PATCH v2] pcihp: fix possible array out of bounds arei.gonglei
@ 2014-08-20 6:05 ` Marcel Apfelbaum
2014-08-20 19:46 ` Michael S. Tsirkin
1 sibling, 0 replies; 3+ messages in thread
From: Marcel Apfelbaum @ 2014-08-20 6:05 UTC (permalink / raw)
To: arei.gonglei; +Cc: peter.crosthwaite, weidong.huang, qemu-devel, mst
On Wed, 2014-08-20 at 13:52 +0800, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> Prevent out-of-bounds array access on
> acpi_pcihp_pci_status.
>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> ---
> v2:
> - change commit message.
> - add 'Reviewed-by'
> ---
> hw/acpi/pcihp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c
> index fae663a..34dedf1 100644
> --- a/hw/acpi/pcihp.c
> +++ b/hw/acpi/pcihp.c
> @@ -231,7 +231,7 @@ static uint64_t pci_read(void *opaque, hwaddr addr, unsigned int size)
> uint32_t val = 0;
> int bsel = s->hotplug_select;
>
> - if (bsel < 0 || bsel > ACPI_PCIHP_MAX_HOTPLUG_BUS) {
> + if (bsel < 0 || bsel >= ACPI_PCIHP_MAX_HOTPLUG_BUS) {
> return 0;
> }
>
Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH v2] pcihp: fix possible array out of bounds
2014-08-20 5:52 [Qemu-devel] [PATCH v2] pcihp: fix possible array out of bounds arei.gonglei
2014-08-20 6:05 ` Marcel Apfelbaum
@ 2014-08-20 19:46 ` Michael S. Tsirkin
1 sibling, 0 replies; 3+ messages in thread
From: Michael S. Tsirkin @ 2014-08-20 19:46 UTC (permalink / raw)
To: arei.gonglei; +Cc: peter.crosthwaite, weidong.huang, qemu-devel, marcel.a
On Wed, Aug 20, 2014 at 01:52:30PM +0800, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> Prevent out-of-bounds array access on
> acpi_pcihp_pci_status.
>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Applied, thanks!
> ---
> v2:
> - change commit message.
> - add 'Reviewed-by'
> ---
> hw/acpi/pcihp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c
> index fae663a..34dedf1 100644
> --- a/hw/acpi/pcihp.c
> +++ b/hw/acpi/pcihp.c
> @@ -231,7 +231,7 @@ static uint64_t pci_read(void *opaque, hwaddr addr, unsigned int size)
> uint32_t val = 0;
> int bsel = s->hotplug_select;
>
> - if (bsel < 0 || bsel > ACPI_PCIHP_MAX_HOTPLUG_BUS) {
> + if (bsel < 0 || bsel >= ACPI_PCIHP_MAX_HOTPLUG_BUS) {
> return 0;
> }
>
> --
> 1.7.12.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-20 19:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-20 5:52 [Qemu-devel] [PATCH v2] pcihp: fix possible array out of bounds arei.gonglei
2014-08-20 6:05 ` Marcel Apfelbaum
2014-08-20 19:46 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).