From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36617)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <knut.omang@oracle.com>) id 1XK26V-00053O-Hq
	for qemu-devel@nongnu.org; Wed, 20 Aug 2014 05:22:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <knut.omang@oracle.com>) id 1XK26O-0006eC-KS
	for qemu-devel@nongnu.org; Wed, 20 Aug 2014 05:22:51 -0400
Received: from aserp1040.oracle.com ([141.146.126.69]:45109)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <knut.omang@oracle.com>) id 1XK26O-0006e5-Dg
	for qemu-devel@nongnu.org; Wed, 20 Aug 2014 05:22:44 -0400
Message-ID: <1408526525.14053.98.camel@abi.no.oracle.com>
From: Knut Omang <knut.omang@oracle.com>
Date: Wed, 20 Aug 2014 11:22:05 +0200
In-Reply-To: <1408525048.13594.49.camel@localhost.localdomain>
References: <1408517610.25437.103.camel@ori.omang.mine.nu>
	<1408525048.13594.49.camel@localhost.localdomain>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/3] ioh3420: Support ARI forwarding
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marcel Apfelbaum <marcel.a@redhat.com>
Cc: Juan Quintela <quintela@redhat.com>, Alexey Kardashevskiy <aik@ozlabs.ru>, "Michael S.Tsirkin" <mst@redhat.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, Gonglei <arei.gonglei@huawei.com>, Igor Mammedov <imammedo@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

On Wed, 2014-08-20 at 11:57 +0300, Marcel Apfelbaum wrote:
> On Wed, 2014-08-20 at 08:53 +0200, Knut Omang wrote:
> > Enable the PCIe capability bit that indicates that this port is able to support
> > and forward requests to > 8 functions for ARI capable devices.
> > 
> > Signed-off-by: Knut Omang <knut.omang@oracle.com>
> > ---
> >  hw/pci-bridge/ioh3420.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/hw/pci-bridge/ioh3420.c b/hw/pci-bridge/ioh3420.c
> > index 8f6c8b0..c14ea6b 100644
> > --- a/hw/pci-bridge/ioh3420.c
> > +++ b/hw/pci-bridge/ioh3420.c
> > @@ -92,8 +92,10 @@ static void ioh3420_reset(DeviceState *qdev)
> >  
> >  static int ioh3420_initfn(PCIDevice *d)
> >  {
> > +    PCIBridge* br = PCI_BRIDGE(d);
> >      PCIEPort *p = PCIE_PORT(d);
> >      PCIESlot *s = PCIE_SLOT(d);
> > +    uint8_t *exp_cap;
> >      int rc;
> >      char tmp[100];
> >      sprintf(tmp, "pcie_port.%d", s->slot);
> > @@ -121,6 +123,10 @@ static int ioh3420_initfn(PCIDevice *d)
> >      if (rc < 0) {
> >          goto err_msi;
> >      }
> > +    /* Support ARI forwarding */
> > +    exp_cap = d->config + d->exp.exp_cap;
> > +    pci_word_test_and_set_mask(exp_cap + PCI_EXP_DEVCAP2, PCI_EXP_DEVCAP2_ARI);
> > +
> Hi,
> 
> I think is better to move the implementation to a function, say pcie_cap_ari_init
> and place it into hw/pci/pcie.c so other devices like downstream ports can use it.

Yes, definitely - I'll fix that, thanks.
Knut

> Thanks,
> Marcel
> 
> >      pcie_cap_deverr_init(d);
> >      pcie_cap_slot_init(d, s->slot);
> >      pcie_chassis_create(s->chassis);
> > @@ -151,6 +157,7 @@ err_bridge:
> >  static void ioh3420_exitfn(PCIDevice *d)
> >  {
> >      PCIESlot *s = PCIE_SLOT(d);
> > +    PCIBridge* br = PCI_BRIDGE(d);
> >  
> >      pcie_aer_exit(d);
> >      pcie_chassis_del_slot(s);
> 
> 
>