From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50597) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKceg-0004fS-IH for qemu-devel@nongnu.org; Thu, 21 Aug 2014 20:24:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XKceW-000585-Vk for qemu-devel@nongnu.org; Thu, 21 Aug 2014 20:24:34 -0400 Received: from e23smtp05.au.ibm.com ([202.81.31.147]:34651) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKceW-00057P-Bf for qemu-devel@nongnu.org; Thu, 21 Aug 2014 20:24:24 -0400 Received: from /spool/local by e23smtp05.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 22 Aug 2014 10:24:19 +1000 From: Samuel Mendoza-Jonas Date: Fri, 22 Aug 2014 10:24:10 +1000 Message-Id: <1408667050-10789-1-git-send-email-sam.mj@au1.ibm.com> Subject: [Qemu-devel] [PATCH V5] spapr: Fix stale HTAB during live migration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org Cc: aik@ozlabs.ru, Samuel Mendoza-Jonas If a guest reboots during a running migration, changes to the hash page table are not necessarily updated on the destination. Opening a new file descriptor to the HTAB forces the migration handler to resend the entire table. Signed-off-by: Samuel Mendoza-Jonas --- Changes in v5: Use mutex on when accessing htab_fd_stale Changes in v4: Readability: need_reset to htab_fd_stale Add spapr_check_htab_fd() and use error_report() Changes in v3: Pointed out by David, htab_save_iterate could potentially try to read before htab_fd is open again. Leave opening the fd to the functions trying to read. Changes in v2: Forgot check on kvmppc_get_htab_fd return value hw/ppc/spapr.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++ include/hw/ppc/spapr.h | 2 ++ 2 files changed, 48 insertions(+) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 3a6d26d..d743308 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -997,6 +997,13 @@ static void spapr_reset_htab(sPAPREnvironment *spapr) /* Kernel handles htab, we don't need to allocate one */ spapr->htab_shift = shift; kvmppc_kern_htab = true; + + /* Tell readers to update their file descriptor */ + pthread_mutex_lock(&spapr->htab_mutex); + if (spapr->htab_fd > 0) { + spapr->htab_fd_stale = true; + } + pthread_mutex_unlock(&spapr->htab_mutex); } else { if (!spapr->htab) { /* Allocate an htab if we don't yet have one */ @@ -1014,6 +1021,30 @@ static void spapr_reset_htab(sPAPREnvironment *spapr) } } +/* A guest reset will cause spapr->htab_fd to become stale if being used. + * Reopen the file descriptor to make sure the whole HTAB is properly read. + */ +static int spapr_check_htab_fd(sPAPREnvironment *spapr) +{ + int rc = 0; + + pthread_mutex_lock(&spapr->htab_mutex); + + if (spapr->htab_fd_stale) { + close(spapr->htab_fd); + spapr->htab_fd = kvmppc_get_htab_fd(false); + if (spapr->htab_fd < 0) { + error_report("Unable to open fd for reading hash table from KVM: " + "%s", strerror(errno)); + rc = -1; + } + spapr->htab_fd_stale = false; + } + + pthread_mutex_unlock(&spapr->htab_mutex); + return rc; +} + static void ppc_spapr_reset(void) { PowerPCCPU *first_ppc_cpu; @@ -1156,7 +1187,10 @@ static int htab_save_setup(QEMUFile *f, void *opaque) } else { assert(kvm_enabled()); + pthread_mutex_lock(&spapr->htab_mutex); spapr->htab_fd = kvmppc_get_htab_fd(false); + spapr->htab_fd_stale = false; + pthread_mutex_unlock(&spapr->htab_mutex); if (spapr->htab_fd < 0) { fprintf(stderr, "Unable to open fd for reading hash table from KVM: %s\n", strerror(errno)); @@ -1309,6 +1343,11 @@ static int htab_save_iterate(QEMUFile *f, void *opaque) if (!spapr->htab) { assert(kvm_enabled()); + rc = spapr_check_htab_fd(spapr); + if (rc < 0) { + return rc; + } + rc = kvmppc_save_htab(f, spapr->htab_fd, MAX_KVM_BUF_SIZE, MAX_ITERATION_NS); if (rc < 0) { @@ -1340,6 +1379,11 @@ static int htab_save_complete(QEMUFile *f, void *opaque) assert(kvm_enabled()); + rc = spapr_check_htab_fd(spapr); + if (rc < 0) { + return rc; + } + rc = kvmppc_save_htab(f, spapr->htab_fd, MAX_KVM_BUF_SIZE, -1); if (rc < 0) { return rc; @@ -1525,6 +1569,8 @@ static void ppc_spapr_init(QEMUMachineInitArgs *args) spapr->htab_shift++; } + pthread_mutex_init(&spapr->htab_mutex, NULL); + /* Set up Interrupt Controller before we create the VCPUs */ spapr->icp = xics_system_init(smp_cpus * kvmppc_smt_threads() / smp_threads, XICS_IRQS); diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h index 0c2e3c5..435309a 100644 --- a/include/hw/ppc/spapr.h +++ b/include/hw/ppc/spapr.h @@ -71,6 +71,8 @@ typedef struct sPAPREnvironment { int htab_save_index; bool htab_first_pass; int htab_fd; + bool htab_fd_stale; + pthread_mutex_t htab_mutex; /* state for Dynamic Reconfiguration Connectors */ sPAPRDrcEntry drc_table[SPAPR_DRC_TABLE_SIZE]; -- 1.9.3