From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35596) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKgjR-0008Kv-0Z for qemu-devel@nongnu.org; Fri, 22 Aug 2014 00:45:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XKgjK-0003gE-RV for qemu-devel@nongnu.org; Fri, 22 Aug 2014 00:45:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60290) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKgjK-0003gA-KC for qemu-devel@nongnu.org; Fri, 22 Aug 2014 00:45:38 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7M4jbuc027354 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 22 Aug 2014 00:45:37 -0400 From: Fam Zheng Date: Fri, 22 Aug 2014 12:45:50 +0800 Message-Id: <1408682750-12738-1-git-send-email-famz@redhat.com> Subject: [Qemu-devel] [PATCH] blkdebug: Delete BH in bdrv_aio_cancel List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi Otherwise error_callback_bh will access the already released acb. Signed-off-by: Fam Zheng --- block/blkdebug.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/block/blkdebug.c b/block/blkdebug.c index 1586ed9..dac7666 100644 --- a/block/blkdebug.c +++ b/block/blkdebug.c @@ -449,6 +449,10 @@ static void error_callback_bh(void *opaque) static void blkdebug_aio_cancel(BlockDriverAIOCB *blockacb) { BlkdebugAIOCB *acb = container_of(blockacb, BlkdebugAIOCB, common); + if (acb->bh) { + qemu_bh_delete(acb->bh); + acb->bh = NULL; + } qemu_aio_release(acb); } -- 2.0.3