From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57868) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKjuk-0001ni-8H for qemu-devel@nongnu.org; Fri, 22 Aug 2014 04:09:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XKjuf-0005xr-D9 for qemu-devel@nongnu.org; Fri, 22 Aug 2014 04:09:38 -0400 Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:55084 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKjuf-0005xe-1y for qemu-devel@nongnu.org; Fri, 22 Aug 2014 04:09:33 -0400 From: Peter Lieven Date: Fri, 22 Aug 2014 10:08:49 +0200 Message-Id: <1408694929-1771-1-git-send-email-pl@kamp.de> Subject: [Qemu-devel] [PATCH] block/iscsi: fix memory corruption on iscsi resize List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, Peter Lieven , qemu-stable@nongnu.org, stefanha@redhat.com bs->total_sectors is not yet updated at this point. resulting in memory corruption if the volume has grown and data is written to the newly availble areas. CC: qemu-stable@nongnu.org Signed-off-by: Peter Lieven --- block/iscsi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/iscsi.c b/block/iscsi.c index a7bb697..ed883c3 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -1509,7 +1509,8 @@ static int iscsi_truncate(BlockDriverState *bs, int64_t offset) if (iscsilun->allocationmap != NULL) { g_free(iscsilun->allocationmap); iscsilun->allocationmap = - bitmap_new(DIV_ROUND_UP(bs->total_sectors, + bitmap_new(DIV_ROUND_UP(sector_lun2qemu(iscsilun->num_blocks, + iscsilun), iscsilun->cluster_sectors)); } -- 1.7.9.5