From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59938) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKk92-0008OG-3g for qemu-devel@nongnu.org; Fri, 22 Aug 2014 04:24:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XKk8x-0001LC-8W for qemu-devel@nongnu.org; Fri, 22 Aug 2014 04:24:24 -0400 From: zhanghailiang Date: Fri, 22 Aug 2014 16:23:51 +0800 Message-ID: <1408695831-11844-1-git-send-email-zhang.zhanghailiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH] linux-user: fix file descriptor leaks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, riku.voipio@iki.fi, luonengjun@huawei.com, peter.huangpeng@huawei.com, zhanghailiang Handle variable "fd_orig" going out of scope leaks the handle. Signed-off-by: zhanghailiang --- linux-user/syscall.c | 1 + 1 file changed, 1 insertion(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index a50229d..11a48c2 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -5082,6 +5082,7 @@ static int open_self_cmdline(void *cpu_env, int fd) if (word_skipped) { if (write(fd, cp_buf, nb_read) != nb_read) { + close(fd_orig); return -1; } } -- 1.7.12.4