From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47966) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKqCq-0001ky-LG for qemu-devel@nongnu.org; Fri, 22 Aug 2014 10:52:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XKqCl-00060o-JL for qemu-devel@nongnu.org; Fri, 22 Aug 2014 10:52:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10220) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKqCl-00060e-CA for qemu-devel@nongnu.org; Fri, 22 Aug 2014 10:52:39 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7MEqcPq010872 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 22 Aug 2014 10:52:38 -0400 From: Kevin Wolf Date: Fri, 22 Aug 2014 16:51:50 +0200 Message-Id: <1408719113-5316-27-git-send-email-kwolf@redhat.com> In-Reply-To: <1408719113-5316-1-git-send-email-kwolf@redhat.com> References: <1408719113-5316-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PULL 26/29] blkdebug: Delete BH in bdrv_aio_cancel List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com From: Fam Zheng Otherwise error_callback_bh will access the already released acb. Cc: qemu-stable@nongnu.org Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- block/blkdebug.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/block/blkdebug.c b/block/blkdebug.c index 95b7244..69b330e 100644 --- a/block/blkdebug.c +++ b/block/blkdebug.c @@ -453,6 +453,10 @@ static void error_callback_bh(void *opaque) static void blkdebug_aio_cancel(BlockDriverAIOCB *blockacb) { BlkdebugAIOCB *acb = container_of(blockacb, BlkdebugAIOCB, common); + if (acb->bh) { + qemu_bh_delete(acb->bh); + acb->bh = NULL; + } qemu_aio_release(acb); } -- 1.8.3.1