From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41091) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKrlA-0002xe-Ls for qemu-devel@nongnu.org; Fri, 22 Aug 2014 12:32:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XKrl4-0004Bh-IE for qemu-devel@nongnu.org; Fri, 22 Aug 2014 12:32:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36449) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKrl4-0004BX-Ba for qemu-devel@nongnu.org; Fri, 22 Aug 2014 12:32:10 -0400 From: Max Reitz Date: Fri, 22 Aug 2014 18:31:35 +0200 Message-Id: <1408725104-17176-2-git-send-email-mreitz@redhat.com> In-Reply-To: <1408725104-17176-1-git-send-email-mreitz@redhat.com> References: <1408725104-17176-1-git-send-email-mreitz@redhat.com> Subject: [Qemu-devel] [PATCH v3 01/10] qcow2: Fix leaks in dirty images List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , =?UTF-8?q?Beno=C3=AEt=20Canet?= , Stefan Hajnoczi , Max Reitz When opening dirty images, qcow2's repair function should not only repair errors but leaks as well. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- block/qcow2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/qcow2.c b/block/qcow2.c index f9e045f..67d6368 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -898,7 +898,7 @@ static int qcow2_open(BlockDriverState *bs, QDict *options, int flags, (s->incompatible_features & QCOW2_INCOMPAT_DIRTY)) { BdrvCheckResult result = {0}; - ret = qcow2_check(bs, &result, BDRV_FIX_ERRORS); + ret = qcow2_check(bs, &result, BDRV_FIX_ERRORS | BDRV_FIX_LEAKS); if (ret < 0) { error_setg_errno(errp, -ret, "Could not repair dirty image"); goto fail; -- 2.0.4