From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
Hu Tao <hutao@cn.fujitsu.com>,
qemu-stable@nongnu.org, Anthony Liguori <aliguori@amazon.com>,
Igor Mammedov <imammedo@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PULL 01/11] hostmem: set MPOL_MF_MOVE
Date: Mon, 25 Aug 2014 00:18:11 +0200 [thread overview]
Message-ID: <1408918641-14167-2-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1408918641-14167-1-git-send-email-mst@redhat.com>
When memory is allocated on a wrong node, MPOL_MF_STRICT
doesn't move it - it just fails the allocation.
A simple way to reproduce the failure is with mlock=on
realtime feature.
The code comment actually says: "ensure policy won't be ignored"
so setting MPOL_MF_MOVE seems like a better way to do this.
Cc: qemu-stable@nongnu.org
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
backends/hostmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/backends/hostmem.c b/backends/hostmem.c
index e7eec37..99e8f99 100644
--- a/backends/hostmem.c
+++ b/backends/hostmem.c
@@ -295,7 +295,7 @@ host_memory_backend_memory_complete(UserCreatable *uc, Error **errp)
/* ensure policy won't be ignored in case memory is preallocated
* before mbind(). note: MPOL_MF_STRICT is ignored on hugepages so
* this doesn't catch hugepage case. */
- unsigned flags = MPOL_MF_STRICT;
+ unsigned flags = MPOL_MF_STRICT | MPOL_MF_MOVE;
/* check for invalid host-nodes and policies and give more verbose
* error messages than mbind(). */
--
MST
next prev parent reply other threads:[~2014-08-24 22:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-24 22:18 [Qemu-devel] [PULL 00/11] pci, pc fixes, features Michael S. Tsirkin
2014-08-24 22:18 ` Michael S. Tsirkin [this message]
2014-08-24 22:18 ` [Qemu-devel] [PULL 02/11] pci_bridge: manually destroy memory regions within PCIBridgeWindows Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 03/11] pcihp: fix possible array out of bounds Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 04/11] pc: reserve more memory for ACPI for new machine types Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 05/11] Add ACPI tables for TPM Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 06/11] ssdt-tpm: add generated hex file to git Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 07/11] pcie: Fix incorrect write to the ari capability next function field Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 08/11] pcie: Rename the pcie_cap_ari_* functions to pcie_cap_arifwd_* Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 09/11] ioh3420: Remove obsoleted, unused ioh3420_init function Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 10/11] ioh3420: Enable ARI forwarding Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 11/11] pcie: fix trailing whitespace Michael S. Tsirkin
2014-08-25 18:42 ` [Qemu-devel] [PULL 00/11] pci, pc fixes, features Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408918641-14167-2-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=aliguori@amazon.com \
--cc=hutao@cn.fujitsu.com \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).