qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Knut Omang <knut.omang@oracle.com>,
	Anthony Liguori <aliguori@amazon.com>
Subject: [Qemu-devel] [PULL 07/11] pcie: Fix incorrect write to the ari capability next function field
Date: Mon, 25 Aug 2014 00:18:37 +0200	[thread overview]
Message-ID: <1408918641-14167-8-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1408918641-14167-1-git-send-email-mst@redhat.com>

From: Knut Omang <knut.omang@oracle.com>

PCI_ARI_CAP_NFN, a macro for reading next function was used instead of
the intended write.

Signed-off-by: Knut Omang <knut.omang@oracle.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 hw/pci/pcie.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
index a123c01..de0e967 100644
--- a/hw/pci/pcie.c
+++ b/hw/pci/pcie.c
@@ -630,5 +630,5 @@ void pcie_ari_init(PCIDevice *dev, uint16_t offset, uint16_t nextfn)
 {
     pcie_add_capability(dev, PCI_EXT_CAP_ID_ARI, PCI_ARI_VER,
                         offset, PCI_ARI_SIZEOF);
-    pci_set_long(dev->config + offset + PCI_ARI_CAP, PCI_ARI_CAP_NFN(nextfn));
+    pci_set_long(dev->config + offset + PCI_ARI_CAP, (nextfn & 0xff) << 8);
 }
-- 
MST

  parent reply	other threads:[~2014-08-24 22:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-24 22:18 [Qemu-devel] [PULL 00/11] pci, pc fixes, features Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 01/11] hostmem: set MPOL_MF_MOVE Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 02/11] pci_bridge: manually destroy memory regions within PCIBridgeWindows Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 03/11] pcihp: fix possible array out of bounds Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 04/11] pc: reserve more memory for ACPI for new machine types Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 05/11] Add ACPI tables for TPM Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 06/11] ssdt-tpm: add generated hex file to git Michael S. Tsirkin
2014-08-24 22:18 ` Michael S. Tsirkin [this message]
2014-08-24 22:18 ` [Qemu-devel] [PULL 08/11] pcie: Rename the pcie_cap_ari_* functions to pcie_cap_arifwd_* Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 09/11] ioh3420: Remove obsoleted, unused ioh3420_init function Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 10/11] ioh3420: Enable ARI forwarding Michael S. Tsirkin
2014-08-24 22:18 ` [Qemu-devel] [PULL 11/11] pcie: fix trailing whitespace Michael S. Tsirkin
2014-08-25 18:42 ` [Qemu-devel] [PULL 00/11] pci, pc fixes, features Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1408918641-14167-8-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=aliguori@amazon.com \
    --cc=knut.omang@oracle.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).