qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Knut Omang <knut.omang@oracle.com>
To: arei.gonglei@huawei.com
Cc: weidong.huang@huawei.com, qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH] ioh3420: Remove unused ioh3420_init() declaration
Date: Mon, 25 Aug 2014 11:15:58 +0200	[thread overview]
Message-ID: <1408958158.14053.193.camel@abi.no.oracle.com> (raw)
In-Reply-To: <1408953257-8196-1-git-send-email-arei.gonglei@huawei.com>

On Mon, 2014-08-25 at 15:54 +0800, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
> 
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
>  hw/pci-bridge/ioh3420.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/hw/pci-bridge/ioh3420.h b/hw/pci-bridge/ioh3420.h
> index 7776e5b..ea423cb 100644
> --- a/hw/pci-bridge/ioh3420.h
> +++ b/hw/pci-bridge/ioh3420.h
> @@ -3,8 +3,4 @@
>  
>  #include "hw/pci/pcie_port.h"
>  
> -PCIESlot *ioh3420_init(PCIBus *bus, int devfn, bool multifunction,
> -                       const char *bus_name, pci_map_irq_fn map_irq,
> -                       uint8_t port, uint8_t chassis, uint16_t slot);
> -
>  #endif /* QEMU_IOH3420_H */

Reviewed-by: Knut Omang <knut.omang@oracle.com>

Knut

  reply	other threads:[~2014-08-25  9:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-25  7:54 [Qemu-devel] [PATCH] ioh3420: Remove unused ioh3420_init() declaration arei.gonglei
2014-08-25  9:15 ` Knut Omang [this message]
2014-08-25  9:48 ` Markus Armbruster
2014-08-25 10:24   ` Knut Omang
2014-08-25 11:51     ` Markus Armbruster
2014-08-25 12:11       ` Gonglei (Arei)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1408958158.14053.193.camel@abi.no.oracle.com \
    --to=knut.omang@oracle.com \
    --cc=arei.gonglei@huawei.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=weidong.huang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).