From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39803) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XLqNs-0004C0-Dx for qemu-devel@nongnu.org; Mon, 25 Aug 2014 05:16:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XLqNm-0002Yo-0o for qemu-devel@nongnu.org; Mon, 25 Aug 2014 05:16:16 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:34101) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XLqNl-0002Yb-QJ for qemu-devel@nongnu.org; Mon, 25 Aug 2014 05:16:09 -0400 Message-ID: <1408958158.14053.193.camel@abi.no.oracle.com> From: Knut Omang Date: Mon, 25 Aug 2014 11:15:58 +0200 In-Reply-To: <1408953257-8196-1-git-send-email-arei.gonglei@huawei.com> References: <1408953257-8196-1-git-send-email-arei.gonglei@huawei.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] ioh3420: Remove unused ioh3420_init() declaration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com Cc: weidong.huang@huawei.com, qemu-devel@nongnu.org, mst@redhat.com On Mon, 2014-08-25 at 15:54 +0800, arei.gonglei@huawei.com wrote: > From: Gonglei > > Signed-off-by: Gonglei > --- > hw/pci-bridge/ioh3420.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/hw/pci-bridge/ioh3420.h b/hw/pci-bridge/ioh3420.h > index 7776e5b..ea423cb 100644 > --- a/hw/pci-bridge/ioh3420.h > +++ b/hw/pci-bridge/ioh3420.h > @@ -3,8 +3,4 @@ > > #include "hw/pci/pcie_port.h" > > -PCIESlot *ioh3420_init(PCIBus *bus, int devfn, bool multifunction, > - const char *bus_name, pci_map_irq_fn map_irq, > - uint8_t port, uint8_t chassis, uint16_t slot); > - > #endif /* QEMU_IOH3420_H */ Reviewed-by: Knut Omang Knut