From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51165) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XLrSR-0001HF-UX for qemu-devel@nongnu.org; Mon, 25 Aug 2014 06:25:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XLrSK-0005Ez-Ce for qemu-devel@nongnu.org; Mon, 25 Aug 2014 06:25:03 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:31262) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XLrSK-0005Et-3i for qemu-devel@nongnu.org; Mon, 25 Aug 2014 06:24:56 -0400 Message-ID: <1408962279.14053.209.camel@abi.no.oracle.com> From: Knut Omang Date: Mon, 25 Aug 2014 12:24:39 +0200 In-Reply-To: <87bnr8sxwd.fsf@blackfin.pond.sub.org> References: <1408953257-8196-1-git-send-email-arei.gonglei@huawei.com> <87bnr8sxwd.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] ioh3420: Remove unused ioh3420_init() declaration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: arei.gonglei@huawei.com, weidong.huang@huawei.com, qemu-devel@nongnu.org, mst@redhat.com On Mon, 2014-08-25 at 11:48 +0200, Markus Armbruster wrote: > writes: >=20 > > From: Gonglei > > > > Signed-off-by: Gonglei > > --- > > hw/pci-bridge/ioh3420.h | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/hw/pci-bridge/ioh3420.h b/hw/pci-bridge/ioh3420.h > > index 7776e5b..ea423cb 100644 > > --- a/hw/pci-bridge/ioh3420.h > > +++ b/hw/pci-bridge/ioh3420.h > > @@ -3,8 +3,4 @@ > > =20 > > #include "hw/pci/pcie_port.h" > > =20 > > -PCIESlot *ioh3420_init(PCIBus *bus, int devfn, bool multifunction, > > - const char *bus_name, pci_map_irq_fn map_irq, > > - uint8_t port, uint8_t chassis, uint16_t slot); > > - > > #endif /* QEMU_IOH3420_H */ >=20 > Breaks the build >=20 > qemu/hw/pci-bridge/ioh3420.c:159:11: warning: no previous prototype f= or =E2=80=98ioh3420_init=E2=80=99 [-Wmissing-prototypes] >=20 > because it removes the prototype of an unused function. Keep both for > future use, or remove both. Michael just pulled in my patch=20 ([PULL 09/11] ioh3420: Remove obsoleted, unused ioh3420_init function) which removed the definition as a result of the review feedback, unfortunately I overlooked the declaration in the header file. Again, sorry for the confusion, Knut