* [Qemu-devel] [PATCH] ioh3420: Remove unused ioh3420_init() declaration @ 2014-08-25 7:54 arei.gonglei 2014-08-25 9:15 ` Knut Omang 2014-08-25 9:48 ` Markus Armbruster 0 siblings, 2 replies; 6+ messages in thread From: arei.gonglei @ 2014-08-25 7:54 UTC (permalink / raw) To: qemu-devel; +Cc: knut.omang, Gonglei, weidong.huang, mst From: Gonglei <arei.gonglei@huawei.com> Signed-off-by: Gonglei <arei.gonglei@huawei.com> --- hw/pci-bridge/ioh3420.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/hw/pci-bridge/ioh3420.h b/hw/pci-bridge/ioh3420.h index 7776e5b..ea423cb 100644 --- a/hw/pci-bridge/ioh3420.h +++ b/hw/pci-bridge/ioh3420.h @@ -3,8 +3,4 @@ #include "hw/pci/pcie_port.h" -PCIESlot *ioh3420_init(PCIBus *bus, int devfn, bool multifunction, - const char *bus_name, pci_map_irq_fn map_irq, - uint8_t port, uint8_t chassis, uint16_t slot); - #endif /* QEMU_IOH3420_H */ -- 1.7.12.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] ioh3420: Remove unused ioh3420_init() declaration 2014-08-25 7:54 [Qemu-devel] [PATCH] ioh3420: Remove unused ioh3420_init() declaration arei.gonglei @ 2014-08-25 9:15 ` Knut Omang 2014-08-25 9:48 ` Markus Armbruster 1 sibling, 0 replies; 6+ messages in thread From: Knut Omang @ 2014-08-25 9:15 UTC (permalink / raw) To: arei.gonglei; +Cc: weidong.huang, qemu-devel, mst On Mon, 2014-08-25 at 15:54 +0800, arei.gonglei@huawei.com wrote: > From: Gonglei <arei.gonglei@huawei.com> > > Signed-off-by: Gonglei <arei.gonglei@huawei.com> > --- > hw/pci-bridge/ioh3420.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/hw/pci-bridge/ioh3420.h b/hw/pci-bridge/ioh3420.h > index 7776e5b..ea423cb 100644 > --- a/hw/pci-bridge/ioh3420.h > +++ b/hw/pci-bridge/ioh3420.h > @@ -3,8 +3,4 @@ > > #include "hw/pci/pcie_port.h" > > -PCIESlot *ioh3420_init(PCIBus *bus, int devfn, bool multifunction, > - const char *bus_name, pci_map_irq_fn map_irq, > - uint8_t port, uint8_t chassis, uint16_t slot); > - > #endif /* QEMU_IOH3420_H */ Reviewed-by: Knut Omang <knut.omang@oracle.com> Knut ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] ioh3420: Remove unused ioh3420_init() declaration 2014-08-25 7:54 [Qemu-devel] [PATCH] ioh3420: Remove unused ioh3420_init() declaration arei.gonglei 2014-08-25 9:15 ` Knut Omang @ 2014-08-25 9:48 ` Markus Armbruster 2014-08-25 10:24 ` Knut Omang 1 sibling, 1 reply; 6+ messages in thread From: Markus Armbruster @ 2014-08-25 9:48 UTC (permalink / raw) To: arei.gonglei; +Cc: weidong.huang, knut.omang, qemu-devel, mst <arei.gonglei@huawei.com> writes: > From: Gonglei <arei.gonglei@huawei.com> > > Signed-off-by: Gonglei <arei.gonglei@huawei.com> > --- > hw/pci-bridge/ioh3420.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/hw/pci-bridge/ioh3420.h b/hw/pci-bridge/ioh3420.h > index 7776e5b..ea423cb 100644 > --- a/hw/pci-bridge/ioh3420.h > +++ b/hw/pci-bridge/ioh3420.h > @@ -3,8 +3,4 @@ > > #include "hw/pci/pcie_port.h" > > -PCIESlot *ioh3420_init(PCIBus *bus, int devfn, bool multifunction, > - const char *bus_name, pci_map_irq_fn map_irq, > - uint8_t port, uint8_t chassis, uint16_t slot); > - > #endif /* QEMU_IOH3420_H */ Breaks the build qemu/hw/pci-bridge/ioh3420.c:159:11: warning: no previous prototype for ‘ioh3420_init’ [-Wmissing-prototypes] because it removes the prototype of an unused function. Keep both for future use, or remove both. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] ioh3420: Remove unused ioh3420_init() declaration 2014-08-25 9:48 ` Markus Armbruster @ 2014-08-25 10:24 ` Knut Omang 2014-08-25 11:51 ` Markus Armbruster 0 siblings, 1 reply; 6+ messages in thread From: Knut Omang @ 2014-08-25 10:24 UTC (permalink / raw) To: Markus Armbruster; +Cc: arei.gonglei, weidong.huang, qemu-devel, mst On Mon, 2014-08-25 at 11:48 +0200, Markus Armbruster wrote: > <arei.gonglei@huawei.com> writes: > > > From: Gonglei <arei.gonglei@huawei.com> > > > > Signed-off-by: Gonglei <arei.gonglei@huawei.com> > > --- > > hw/pci-bridge/ioh3420.h | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/hw/pci-bridge/ioh3420.h b/hw/pci-bridge/ioh3420.h > > index 7776e5b..ea423cb 100644 > > --- a/hw/pci-bridge/ioh3420.h > > +++ b/hw/pci-bridge/ioh3420.h > > @@ -3,8 +3,4 @@ > > > > #include "hw/pci/pcie_port.h" > > > > -PCIESlot *ioh3420_init(PCIBus *bus, int devfn, bool multifunction, > > - const char *bus_name, pci_map_irq_fn map_irq, > > - uint8_t port, uint8_t chassis, uint16_t slot); > > - > > #endif /* QEMU_IOH3420_H */ > > Breaks the build > > qemu/hw/pci-bridge/ioh3420.c:159:11: warning: no previous prototype for ‘ioh3420_init’ [-Wmissing-prototypes] > > because it removes the prototype of an unused function. Keep both for > future use, or remove both. Michael just pulled in my patch ([PULL 09/11] ioh3420: Remove obsoleted, unused ioh3420_init function) which removed the definition as a result of the review feedback, unfortunately I overlooked the declaration in the header file. Again, sorry for the confusion, Knut ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] ioh3420: Remove unused ioh3420_init() declaration 2014-08-25 10:24 ` Knut Omang @ 2014-08-25 11:51 ` Markus Armbruster 2014-08-25 12:11 ` Gonglei (Arei) 0 siblings, 1 reply; 6+ messages in thread From: Markus Armbruster @ 2014-08-25 11:51 UTC (permalink / raw) To: Knut Omang; +Cc: arei.gonglei, weidong.huang, qemu-devel, mst Knut Omang <knut.omang@oracle.com> writes: > On Mon, 2014-08-25 at 11:48 +0200, Markus Armbruster wrote: >> <arei.gonglei@huawei.com> writes: >> >> > From: Gonglei <arei.gonglei@huawei.com> >> > >> > Signed-off-by: Gonglei <arei.gonglei@huawei.com> >> > --- >> > hw/pci-bridge/ioh3420.h | 4 ---- >> > 1 file changed, 4 deletions(-) >> > >> > diff --git a/hw/pci-bridge/ioh3420.h b/hw/pci-bridge/ioh3420.h >> > index 7776e5b..ea423cb 100644 >> > --- a/hw/pci-bridge/ioh3420.h >> > +++ b/hw/pci-bridge/ioh3420.h >> > @@ -3,8 +3,4 @@ >> > >> > #include "hw/pci/pcie_port.h" >> > >> > -PCIESlot *ioh3420_init(PCIBus *bus, int devfn, bool multifunction, >> > - const char *bus_name, pci_map_irq_fn map_irq, >> > - uint8_t port, uint8_t chassis, uint16_t slot); >> > - >> > #endif /* QEMU_IOH3420_H */ >> >> Breaks the build >> >> qemu/hw/pci-bridge/ioh3420.c:159:11: warning: no previous >> prototype for ‘ioh3420_init’ [-Wmissing-prototypes] >> >> because it removes the prototype of an unused function. Keep both for >> future use, or remove both. > > Michael just pulled in my patch > ([PULL 09/11] ioh3420: Remove obsoleted, unused ioh3420_init function) > > which removed the definition as a result of the review feedback, > unfortunately I overlooked the declaration in the header file. > > Again, sorry for the confusion, Gonglei, please make sure to state patch prerequisites. In this case, you should've pointed to Knut's patch in the commit message. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] ioh3420: Remove unused ioh3420_init() declaration 2014-08-25 11:51 ` Markus Armbruster @ 2014-08-25 12:11 ` Gonglei (Arei) 0 siblings, 0 replies; 6+ messages in thread From: Gonglei (Arei) @ 2014-08-25 12:11 UTC (permalink / raw) To: Markus Armbruster, Knut Omang Cc: Huangweidong (C), qemu-devel@nongnu.org, mst@redhat.com > From: Markus Armbruster [mailto:armbru@redhat.com] > Sent: Monday, August 25, 2014 7:51 PM > Subject: Re: [Qemu-devel] [PATCH] ioh3420: Remove unused ioh3420_init() > declaration > > Knut Omang <knut.omang@oracle.com> writes: > > > On Mon, 2014-08-25 at 11:48 +0200, Markus Armbruster wrote: > >> <arei.gonglei@huawei.com> writes: > >> > >> > From: Gonglei <arei.gonglei@huawei.com> > >> > > >> > Signed-off-by: Gonglei <arei.gonglei@huawei.com> > >> > --- > >> > hw/pci-bridge/ioh3420.h | 4 ---- > >> > 1 file changed, 4 deletions(-) > >> > > >> > diff --git a/hw/pci-bridge/ioh3420.h b/hw/pci-bridge/ioh3420.h > >> > index 7776e5b..ea423cb 100644 > >> > --- a/hw/pci-bridge/ioh3420.h > >> > +++ b/hw/pci-bridge/ioh3420.h > >> > @@ -3,8 +3,4 @@ > >> > > >> > #include "hw/pci/pcie_port.h" > >> > > >> > -PCIESlot *ioh3420_init(PCIBus *bus, int devfn, bool multifunction, > >> > - const char *bus_name, pci_map_irq_fn > map_irq, > >> > - uint8_t port, uint8_t chassis, uint16_t slot); > >> > - > >> > #endif /* QEMU_IOH3420_H */ > >> > >> Breaks the build > >> > >> qemu/hw/pci-bridge/ioh3420.c:159:11: warning: no previous > >> prototype for ‘ioh3420_init’ [-Wmissing-prototypes] > >> > >> because it removes the prototype of an unused function. Keep both for > >> future use, or remove both. > > > > Michael just pulled in my patch > > ([PULL 09/11] ioh3420: Remove obsoleted, unused ioh3420_init function) > > > > which removed the definition as a result of the review feedback, > > unfortunately I overlooked the declaration in the header file. > > > > Again, sorry for the confusion, > > Gonglei, please make sure to state patch prerequisites. In this case, > you should've pointed to Knut's patch in the commit message. OK. Thanks for your point, Markus! v2 will be post. Best regards, -Gonglei ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-08-25 12:11 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-08-25 7:54 [Qemu-devel] [PATCH] ioh3420: Remove unused ioh3420_init() declaration arei.gonglei 2014-08-25 9:15 ` Knut Omang 2014-08-25 9:48 ` Markus Armbruster 2014-08-25 10:24 ` Knut Omang 2014-08-25 11:51 ` Markus Armbruster 2014-08-25 12:11 ` Gonglei (Arei)
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).