From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49977) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XLzuN-0005Jz-9k for qemu-devel@nongnu.org; Mon, 25 Aug 2014 15:26:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XLzuH-0002JJ-Aj for qemu-devel@nongnu.org; Mon, 25 Aug 2014 15:26:27 -0400 From: Tom Musta Date: Mon, 25 Aug 2014 14:25:39 -0500 Message-Id: <1408994744-17312-2-git-send-email-tommusta@gmail.com> In-Reply-To: <1408994744-17312-1-git-send-email-tommusta@gmail.com> References: <1408994744-17312-1-git-send-email-tommusta@gmail.com> Subject: [Qemu-devel] [PATCH 1/6] target-ppc: Special Case of rlwimi Should Use Deposit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org Cc: Tom Musta , agraf@suse.de, rth@twiddle.net The special case of rlwimi where MB <= ME and SH = 31-ME can be implemented with a single TCG deposit operation. This replaces the less general case of SH = MB = 0 and ME = 31. Signed-off-by: Tom Musta Suggested-by: Richard Henderson --- target-ppc/translate.c | 9 +++------ 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index 47dc903..095b83c 100644 --- a/target-ppc/translate.c +++ b/target-ppc/translate.c @@ -1636,12 +1636,9 @@ static void gen_rlwimi(DisasContext *ctx) mb = MB(ctx->opcode); me = ME(ctx->opcode); sh = SH(ctx->opcode); - if (likely(sh == 0 && mb == 0 && me == 31)) { -#if defined(TARGET_PPC64) - tcg_gen_mov_i64(cpu_gpr[rA(ctx->opcode)], cpu_gpr[rS(ctx->opcode)]); -#else - tcg_gen_ext32u_tl(cpu_gpr[rA(ctx->opcode)], cpu_gpr[rS(ctx->opcode)]); -#endif + if (likely(sh == (31-me) && mb <= me)) { + tcg_gen_deposit_tl(cpu_gpr[rA(ctx->opcode)], cpu_gpr[rA(ctx->opcode)], + cpu_gpr[rS(ctx->opcode)], sh, me - mb + 1); } else { target_ulong mask; TCGv t1; -- 1.7.1