qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org, "Andreas Färber" <afaerber@suse.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Aurelien Jarno <aurelien@aurel32.net>,
	kvm@vger.kernel.org
Subject: [Qemu-devel] [PATCH v2 3/6] target-i386: Disable CPUID_ACPI by default on KVM mode
Date: Mon, 25 Aug 2014 17:45:47 -0300	[thread overview]
Message-ID: <1408999550-20321-4-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1408999550-20321-1-git-send-email-ehabkost@redhat.com>

KVM never supported the CPUID_ACPI flag, so it doesn't make sense to
have it enabled by default when KVM is enabled.

The motivation here is exactly the same we had for the MONITOR flag
(disabled by commit 136a7e9a85d7047461f8153f7d12c514a3d68f69).

And like on the MONITOR flag case, we don't need machine-type compat code
because it is currently impossible to run a KVM VM with the ACPI flag set.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 target-i386/cpu.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 0396410..b7fc6e0 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -461,6 +461,7 @@ static uint32_t kvm_default_features[FEATURE_WORDS] = {
 /* Features that are not added by default to any CPU model when KVM is enabled.
  */
 static uint32_t kvm_default_unset_features[FEATURE_WORDS] = {
+    [FEAT_1_EDX] = CPUID_ACPI,
     [FEAT_1_ECX] = CPUID_EXT_MONITOR,
 };
 
-- 
1.9.3

  parent reply	other threads:[~2014-08-25 20:46 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-25 20:45 [Qemu-devel] [PATCH v2 0/6] target-i386: Make most CPU models work with "enforce" out of the box Eduardo Habkost
2014-08-25 20:45 ` [Qemu-devel] [PATCH v2 1/6] pc: Create pc_compat_2_1() functions Eduardo Habkost
2014-08-25 20:45 ` [Qemu-devel] [PATCH v2 2/6] target-i386: Rename KVM auto-feature-enable compat function Eduardo Habkost
2014-08-25 20:45 ` Eduardo Habkost [this message]
2014-08-25 20:45 ` [Qemu-devel] [PATCH v2 4/6] target-i386: Remove unsupported bits from all CPU models Eduardo Habkost
2014-08-25 20:45 ` [Qemu-devel] [PATCH v2 5/6] target-i386: Don't enable nested VMX by default Eduardo Habkost
2014-08-25 20:45 ` [Qemu-devel] [PATCH v2 6/6] target-i386: Disable SVM by default in KVM mode Eduardo Habkost
2014-08-26 12:56 ` [Qemu-devel] [PATCH v2 0/6] target-i386: Make most CPU models work with "enforce" out of the box Paolo Bonzini
2014-08-26 18:01   ` Eduardo Habkost
2014-08-27 13:36     ` Paolo Bonzini
2014-08-27 14:05       ` Eduardo Habkost
2014-08-27 14:33         ` Paolo Bonzini
2014-08-27 15:42           ` Eduardo Habkost
2014-08-27 15:58             ` Andreas Färber
2014-08-27 16:08               ` Eduardo Habkost
2014-08-27 16:14                 ` Andreas Färber
2014-08-27 16:18                 ` Paolo Bonzini
2014-08-27 16:34                   ` Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1408999550-20321-4-git-send-email-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=afaerber@suse.de \
    --cc=aurelien@aurel32.net \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).